Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datetime isNot filter #1158

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

kpodp0ra
Copy link
Collaborator

@kpodp0ra kpodp0ra commented Dec 11, 2024

Closes GH-1157

This pull request addresses an issue in the SQL query construction for "is not" filter applied to Date fields. Previously, the generated SQL lacked proper grouping (via parentheses), leading to incorrect logical evaluation of combined filters. This fix ensures that logical conditions are correctly grouped, allowing filters to work as expected.

@tea-artist tea-artist requested a review from caoxing9 December 11, 2024 03:06
Copy link
Contributor

@caoxing9 caoxing9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caoxing9 caoxing9 merged commit 3968cab into teableio:develop Dec 12, 2024
8 of 9 checks passed
@kpodp0ra kpodp0ra deleted the fix-datetime branch December 12, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect SQL logic for "is not" date filter
2 participants