feat: more context menu actions #1135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
caoxing9
reviewed
Dec 11, 2024
apps/nextjs-app/src/features/app/blocks/space/space-side-bar/SpaceItem.tsx
Outdated
Show resolved
Hide resolved
caoxing9
reviewed
Dec 11, 2024
apps/nextjs-app/src/features/app/blocks/table-list/TableListItem.tsx
Outdated
Show resolved
Hide resolved
caoxing9
reviewed
Dec 11, 2024
apps/nextjs-app/src/features/app/blocks/view/list/ViewListItem.tsx
Outdated
Show resolved
Hide resolved
Sky-FE
reviewed
Dec 12, 2024
Sky-FE
approved these changes
Dec 12, 2024
demo.mp4 |
|
Interesting 👀. I will try to fix it on my free time. |
|
Rebased PR onto develop branch. Ready to merge. |
caoxing9
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1123
Added right-click action to open this context menu
Added right-click action to table selection menu
Replaced onBlur with useClickAway, because table rename via context menu caused troubles in Firefox
Added right-click action to views
Made PopoverTrigger slightly bigger there, so you can click on view's button edge and still open context menu