fix: show table's context menu without table|delete permissions #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is quite an embarrassing bug 😅 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes fragment "
{menuPermission.deleteTable && (", that was added Jan 24, 2024 when the only action in context menu was table deleting. Times have changed and now there are more things in this menu.Interestingly, in the codebase there is already the code that hides the menu when the user doesn't have permissions to all available actions:
teable/apps/nextjs-app/src/features/app/blocks/table-list/TableOperation.tsx
Lines 84 to 86 in e6c7fd9
So "
{menuPermission.deleteTable && (" can be safely deleted without any consequences.