Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Add an Authentication Header for External REST API Authentication #1759

Merged
merged 14 commits into from
Jun 3, 2024

Conversation

cenk1cenk2
Copy link
Contributor

Dear @tchiotludo,

Thank you for your time on still maintaining and improving this project and very excited for the upcoming release.

I have added a draft where it will allow users that are using the external REST authentication method to add a single authentication header while they are doing their requests.

This might become useful, at least in our case is, where the external authentication API is also exposed to the internet, and the user wants to limit this access just through a static token that is passed through the service.

This draft implements this functionality in the most basic form with the ability to add a single header to the request.

I would kindly request you to inform me back and what I can improve if you find this feature also a feasible thing to add to the next release.

@tchiotludo
Copy link
Owner

hey @cenk1cenk2, I think it will make more sense to add a generic headers that will be a list of custom header using this configuration:

      headers:
        - name: "Authorization"
          value: Bearer your-token
        - name: "X-Api-Key"
          value: "azerty"

@cenk1cenk2
Copy link
Contributor Author

Thank you for the guidance @tchiotludo, I have updated it accordingly.

I hope it is up to snuff with my non-existent Java expertise.

@Lolo1883
Copy link

Lolo1883 commented Jun 3, 2024

@tchiotludo
Hey, we tried the current implementing in prod with those headers and HttpClient and it works!!
if you want to push this forward that would be very great!
Thanks

@tchiotludo tchiotludo merged commit 40b4bed into tchiotludo:dev Jun 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants