Skip to content

Commit

Permalink
github: add 2 testing combinations back to the matrix
Browse files Browse the repository at this point in the history
this change adds the combinations of

- {compiler: clang++-18, standard: 23, mode: release}
- {compiler: clang++-18, standard: 23, mode: debug}

back.

before this change, the `include` keyword instructs
github workflow to override these two combinations with
the ones which builds with dpdk and with C++20 modules.
this hurts the coverage of the test matrix.

after this change, instead of using `include` keyword,
we just add two more jobs which are dedicated for
testing these two combinations without overriding
the existing ones.

Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov committed May 17, 2024
1 parent 51dcb51 commit f6072b5
Showing 1 changed file with 23 additions and 48 deletions.
71 changes: 23 additions & 48 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ concurrency:
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}

jobs:
test:
name: "Tests (${{ matrix.compiler }}, C++${{ matrix.standard}}, ${{ matrix.mode }}, ${{ matrix.enables }})"
regular_test:
name: "Test (${{ matrix.compiler }}, C++${{ matrix.standard}}, ${{ matrix.mode }})"
uses: ./.github/workflows/test.yaml
strategy:
fail-fast: false
Expand All @@ -20,55 +20,30 @@ jobs:
compiler: [clang++-18, gcc-13]
standard: [20, 23]
mode: [dev, debug, release]
include:
- compiler: clang++-18
standard: 20
mode: dev
- compiler: clang++-18
standard: 20
mode: debug
- compiler: clang++-18
standard: 20
mode: release
- compiler: clang++-18
standard: 23
mode: dev
- compiler: clang++-18
standard: 23
mode: debug
- compiler: clang++-18
standard: 23
mode: release
- compiler: gcc-13
standard: 20
mode: dev
- compiler: gcc-13
standard: 20
mode: debug
- compiler: gcc-13
standard: 20
mode: release
- compiler: gcc-13
standard: 23
mode: dev
- compiler: gcc-13
standard: 23
mode: debug
- compiler: gcc-13
standard: 23
mode: release
- compiler: clang++-18
standard: 23
mode: release
options: --cook dpdk --dpdk-machine haswell
enables: --enable-dpdk
- compiler: clang++-18
standard: 23
mode: debug
enables: --enable-cxx-modules
with:
compiler: ${{ matrix.compiler }}
standard: ${{ matrix.standard }}
mode: ${{ matrix.mode }}
enables: ${{ matrix.enables }}
options: ${{ matrix.options }}
build_with_dpdk:
name: "Test with DPDK enabled (${{ matrix.compiler }}, C++${{ matrix.standard}}, ${{ matrix.mode }})"
uses: ./.github/workflows/test.yaml
strategy:
fail-fast: false
with:
compiler: clang++-18
standard: 23
mode: release
enables: --enable-dpdk
options: --cook dpdk --dpdk-machine haswell
build_with_cxx_modules:
name: "Test with C++20 modules enabled (${{ matrix.compiler }}, C++${{ matrix.standard}}, ${{ matrix.mode }})"
uses: ./.github/workflows/test.yaml
strategy:
fail-fast: false
with:
compiler: clang++-18
standard: 23
mode: debug
enables: --enable-cxx-modules

0 comments on commit f6072b5

Please sign in to comment.