core/app_template: return status code 0 for --help

if user queries the usage of an seastar application using `--help`, `--help-seastar` or `--help-loggers`, he/she should not be greeted with a non-zero status code, which implies an error in general. but in this case, there is no errors. so we should return 0 as the status code. Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2213
tchaikov · May 2, 2024 · b8a13be · b8a13be
1 parent 80f8065
commit b8a13be
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/core/app-template.cc b/src/core/app-template.cc
@@ -212,15 +212,15 @@ app_template::run_deprecated(int ac, char ** av, std::function<void ()>&& func)
  std::cout << _opts.description << "\n";
  }
  std::cout << _app_opts << "\n";
- return 1;
+ return 0;
  }
  if (configuration.count("help-seastar")) {
  std::cout << _seastar_opts << "\n";
- return 1;
+ return 0;
  }
  if (configuration.count("help-loggers")) {
  log_cli::print_available_loggers(std::cout);
- return 1;
+ return 0;
  }
 
  try {