Skip to content

Commit

Permalink
std-compat: remove #include:s which were added for pre C++17
Browse files Browse the repository at this point in the history
these `#include`s were introduced by 0bbcbba and 79e846e, for backward
compatibility with pre-C++17 era. since we've dropped C++17 support,
and now only support C++20 and up. let's remove these cruft.

Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov committed May 21, 2024
1 parent 67a14f9 commit 9984358
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 8 deletions.
1 change: 1 addition & 0 deletions include/seastar/core/resource.hh
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#ifndef SEASTAR_MODULE
#include <cassert>
#include <cstdlib>
#include <optional>
#include <string>
#include <vector>
#include <set>
Expand Down
2 changes: 1 addition & 1 deletion include/seastar/util/exceptions.hh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

#pragma once

#include <seastar/util/std-compat.hh>
#include <filesystem>

namespace seastar {

Expand Down
2 changes: 1 addition & 1 deletion include/seastar/util/read_first_line.hh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <seastar/util/std-compat.hh>
#include <filesystem>
#include <seastar/core/sstring.hh>
#ifndef SEASTAR_MODULE
#include <boost/lexical_cast.hpp>
Expand Down
6 changes: 0 additions & 6 deletions include/seastar/util/std-compat.hh
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@

#ifndef SEASTAR_MODULE

#include <optional>
#include <string_view>
#include <variant>

#include <filesystem>

#if __has_include(<memory_resource>)
#include <memory_resource>
#else
Expand Down
1 change: 1 addition & 0 deletions src/net/config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ module;
#include <yaml-cpp/yaml.h>
#include <algorithm>
#include <istream>
#include <optional>
#include <unordered_map>
#include <string>

Expand Down

0 comments on commit 9984358

Please sign in to comment.