Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: update upload-artifact action prior to deprecation #3506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Dec 6, 2024

@ljharb ljharb added the meta label Dec 6, 2024
@ljharb ljharb requested a review from a team December 6, 2024 18:17
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Dec 6, 2024
@bakkot
Copy link
Contributor

bakkot commented Dec 6, 2024

I'm assuming this:

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times.

isn't going to be a problem.

@ljharb
Copy link
Member Author

ljharb commented Dec 6, 2024

Correct, since we don't upload jobs in a matrix. I read the docs just in case, and there's a way to merge differently named artifacts anyways, so it'd be a straightforward migration if we were.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants