Editorial: Add an Assertion for Built-in Function Object #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Dec 18, 2024
michaelficarra
approved these changes
Dec 18, 2024
michaelficarra
added
ready to merge
ljharb
pushed a commit
to kimjg1119/ecma262
that referenced
this pull request
Dec 18, 2024
ljharb
force-pushed
the
built-in-function
branch
from
46b6194 to
49f42e3
Compare
ljharb
force-pushed
the
built-in-function
branch
from
49f42e3 to
38f68d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Construct method for built-in function object, it seems that the result must be an object. However, current ESMeta is unable to check this since BuiltinCallOrConstruct handles Call and Construct together.
It will be helpful to add an assertion to resolve a false alarm.
ESMeta alarm: