HDF5-based format: update detection of HDF5 version for UTF-8-based filenames #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilenames A couple of years ago HDF5 changed its filename handling on Windows: instead of taking filenames in the local codepage (as previously), it now takes filenames in UTF-8 and converts them to wchar_t-based names, using the corresponding "Unicode" Windows API functions to access files. (This is to ensure that all stored files can be accessed, not just those with names representable in the local codepage.) matio also does the same since commit 6d47ebd. In contrast to the official release notes and documentation of HDF5, the first version of HDF5 that the change happend in was actually 1.10.6. This was commit 34adba4a0c131afe49a75e8e7d92f1e986c1b540 in the HDF5 repository, which is part of 1.10.6 and further. The commit itself appears to be a cherry-pick of other changes, so it is likely that this was not intentional back then, and that HDF5 1.12.0 was to be the first version with the change (hence the development version 1.11.6 for the check) -- however, this does not change the fact that in the actual releases this change was made already in 1.10.6. matio passes 8bit strings directly to HDF5, so the change itself is mostly transparent to matio (with matio just using the behavior of the underlying HDF5 library), but when writing .mat files matio does need to update the file header so that matlab recognizes it as a .mat (and not a generic HDF5 file). For that it needs to open the same file that was written by the HDF5 library previously. This commit updates the compiler check that detects which version of HDF5 is being used from 1.11.6 to 1.10.6, so that it correctly aligns with the behavior of HDF5.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #236 here is the dependent change that updates the minimum HDF5 version to 1.10.6. The commit message contains a longer explanation for the rationale behind the change.