fix(cli): Statically compile msvc runtime #11769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #11642 ref swc-project/swc#7965 i only added it for x64 for now but we should monitor x32 (swc removed it for this one again) and aarch64 (swc never added it). x32 is fairly rare as a dev system and aarch64 didn't seem much testing in general (as a dev system) so i'd prefer to wait and see if it's needed. note that i don't know if any other tooling (rust etc) need the dyn runtime so that's also something to monitor
Package Changes Through 8b60959There are 8 changes which include @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
ngl, not sure if i really like this or if we should just list it as a required system dependency... |
lucasfernog
previously approved these changes
Dec 2, 2024
|
as long as it helps our users i'm fine with it.. though most people should have msvc installed right? |
amrbashir
reviewed
Dec 3, 2024
amrbashir
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11642 ref swc-project/swc#7965
i only added it for x64 for now but we should monitor x32 (swc removed it for this one again) and aarch64 (swc never added it). x32 is fairly rare as a dev system and aarch64 didn't seem much testing in general (as a dev system) so i'd prefer to wait and see if it's needed.
note that i don't know if any other tooling (rust etc) need the dyn runtime so that's also something to monitor