-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli): use cargo run
for tauri dev
#11694
Conversation
Package Changes Through 43e8949There are 8 changes which include @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
also, most of the changes were done last week, postponed due to system issues which is probably why i don't know what was wrong with it anymore x) |
I left the DevProcess stuff as a todo because it requires touching code shared by mobile and desktop. I'd prefer to wait and see if we need anything of the "disabled" code after some real world testing and remove it later incl a small refactor rather than removing it now and reverting some stuff. If you disagree i can do it still but idk when i have the time for that. p.s. the lint workflow fails in unrelated parts of the codebase |
(accidentally dismissed your review and can't merge my own prs in this repo without an approval) |
closes #4724
edit: closes #8169
Soooo i have small problem here. I debugged this for so long (hours) that i don't even remember why i was debugging it. The only difference between the current behavior and this PR is a new error message on ctrlc but i think this
cargo run
is printing that.i would appreciate some testing and telling me what i missed.
p.s. the cargo check workflow will fail. didn't want to remove DevCleanup and manually_killed until someone tells me what i missed.
p.p.s. i'll try to do some refactoring after this gets merged. the whole cli dev/build impl is a bit convoluted 😅
p.p.p.s idk why github messes up the diff this much, it's better in vscode for me