Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): use cargo run for tauri dev #11694

Merged
merged 8 commits into from
Dec 5, 2024
Merged

Conversation

FabianLars
Copy link
Member

@FabianLars FabianLars commented Nov 14, 2024

closes #4724
edit: closes #8169

Soooo i have small problem here. I debugged this for so long (hours) that i don't even remember why i was debugging it. The only difference between the current behavior and this PR is a new error message on ctrlc but i think this cargo run is printing that.

i would appreciate some testing and telling me what i missed.

p.s. the cargo check workflow will fail. didn't want to remove DevCleanup and manually_killed until someone tells me what i missed.

p.p.s. i'll try to do some refactoring after this gets merged. the whole cli dev/build impl is a bit convoluted 😅

p.p.p.s idk why github messes up the diff this much, it's better in vscode for me

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Package Changes Through 43e8949

There are 8 changes which include @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.1.1 2.2.0
tauri-utils 2.1.0 2.1.1
tauri-bundler 2.1.0 2.2.0
tauri-runtime 2.2.0 2.3.0
tauri-runtime-wry 2.2.0 2.3.0
tauri-codegen 2.0.3 2.0.4
tauri-macros 2.0.3 2.0.4
tauri-plugin 2.0.3 2.0.4
tauri-build 2.0.3 2.0.4
tauri 2.1.1 2.2.0
@tauri-apps/cli 2.1.0 2.2.0
tauri-cli 2.1.0 2.2.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member Author

also, most of the changes were done last week, postponed due to system issues which is probably why i don't know what was wrong with it anymore x)

@FabianLars FabianLars marked this pull request as ready for review November 26, 2024 19:10
@FabianLars FabianLars requested a review from a team as a code owner November 26, 2024 19:10
@FabianLars
Copy link
Member Author

I left the DevProcess stuff as a todo because it requires touching code shared by mobile and desktop. I'd prefer to wait and see if we need anything of the "disabled" code after some real world testing and remove it later incl a small refactor rather than removing it now and reverting some stuff.

If you disagree i can do it still but idk when i have the time for that.

p.s. the lint workflow fails in unrelated parts of the codebase

lucasfernog
lucasfernog previously approved these changes Dec 2, 2024
@FabianLars
Copy link
Member Author

(accidentally dismissed your review and can't merge my own prs in this repo without an approval)

@lucasfernog lucasfernog merged commit 2b8a981 into dev Dec 5, 2024
13 checks passed
@lucasfernog lucasfernog deleted the fix/dev-cargo-run branch December 5, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants