-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dialog): add showFolderPicker
to iOS and android targets
#2322
base: v2
Are you sure you want to change the base?
Conversation
Package Changes Through 6122f43There are 10 changes which include clipboard-manager with patch, clipboard-manager-js with patch, dialog with patch, dialog-js with patch, http with minor, http-js with minor, log with patch, log-js with patch, updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Awesome, thanks so much! I don't have any complains other than the CI. Your changes seem to work in my testing (though i didn't connect it to file reading/writing yet), nice work :) |
@FabianLars Just tested file writing. The uri from the folder picker on ios works perfectly with the URI returned e.g. if there is a folder already created called Test in Download
In android however the URI does not work directly. If for example we select the same folder and do as we did before we get an invalid URI error. e.g. content://com.android.externalstorage.documents/tree/primary%3ADownload%2FTest In order to write to that folder this would need to be transformed to the following.
This is more of a stylistic choice IMO and Im not sure if this is already an existing quirk of the android filesystem so I'm looking for some insight as to whether I should correct this. Here is a repository if you are looking to reproduce. |
@lucasfernog Are you available in the near future to take a look at this? Really unsure on how to best connect it to the fs plugin and i'm afraid that we end up having to change the return value of this plugin so i'm a bit hesitant to merge it rn. |
Add the folder picker to iOS and android. Ready for review!