Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update osu and .NET #446

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Update osu and .NET #446

merged 2 commits into from
Feb 20, 2024

Conversation

LumpBloom7
Copy link
Collaborator

Needed to be done anyways, since dependabot wouldn't bump osu due to .NET upgrade

@LumpBloom7 LumpBloom7 added the dependencies Pull requests that update a dependency file label Feb 19, 2024
@LumpBloom7
Copy link
Collaborator Author

The ApplyResult has been changed to utilize the new overload that doesn't require a delegate. And usage of ApplyCustomResult or whatever has moved out into the ApplyResult method. As far as my testing goes, seems to work just fine with a few test plays, but I'll leave it for another person to have a pass.

PS: I'm not gonna bother with NVika, since most of the complains don't even concern my changes.

naoei
naoei approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@naoei naoei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

.github/workflows/ci.yml Show resolved Hide resolved
@naoei naoei merged commit bb269f6 into master Feb 20, 2024
7 of 8 checks passed
@naoei naoei deleted the Bump-osu-and-NET branch February 20, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naoei naoei naoei approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LumpBloom7 @naoei