Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove routing mark #812

Open
sindresorhus opened this issue Feb 2, 2014 · 18 comments
Open

Remove routing mark #812

sindresorhus opened this issue Feb 2, 2014 · 18 comments

Comments

@sindresorhus
Copy link
Member

This one is also not very useful. We should instead strive to get all the apps to implement routing.

Blocked by Let's also check if we want to keep all of the current examples. in #735

@ColinEberhardt
Copy link
Member

Agreed - the majority do implement routing, so I would push to have all implement it.

@arthurvr
Copy link
Member

Agreed - the majority do implement routing, so I would push to have all implement it.

Shall I ping the authors of all apps that don't have routing yet in this issue? It's getting time to implement it :)

@sindresorhus
Copy link
Member Author

Yes.

@addyosmani
Copy link
Member

Yes please!

@arthurvr
Copy link
Member

arthurvr commented Mar 27, 2015

Hey folks! Could y'all checkout this issue? We'd love to have routing integrated in all apps. You can use the existing apps as example. Be sure to read the app spec as well.

Thanks!

@podefr
Copy link
Contributor

podefr commented Mar 27, 2015

hey, thanks for the ping. I'll add routing to Olives and will create a pull request.

@arthurvr
Copy link
Member

Great, thanks!

@mckamey
Copy link
Contributor

mckamey commented May 10, 2015

@arthurvr I am interested in updating for DUEL. Life has been busy but will check it out soon.

@arthurvr
Copy link
Member

Hey @podefr, is there still interest in picking this up? Thanks!

@podefr
Copy link
Contributor

podefr commented May 17, 2015

Yes @arthurvr, I'll take care of this

@arthurvr
Copy link
Member

ping @podefr :)

@podefr
Copy link
Contributor

podefr commented May 29, 2015

@arthurvr I can't give you an ETA, when do you need this for? It may take a couple of months. The problem isn't the router as I've got this working somewhere in a new branch, but I need to implement a new feature to be able to filter a model without breaking data-binding, and this may take a while due to priorities.

@arthurvr
Copy link
Member

@podefr No problem I guess :) Keep us updated.

@arthurvr
Copy link
Member

arthurvr commented Jun 7, 2015

@mckamey still interested?

@mckamey
Copy link
Contributor

mckamey commented Jun 7, 2015

@arthurvr, yes still interested. I have a newborn at home so life is quite busy.

@arthurvr
Copy link
Member

arthurvr commented Jun 8, 2015

No worries @mckamey. Congrats!

@arthurvr
Copy link
Member

ping @mckamey

mckamey added a commit to mckamey/todomvc that referenced this issue Sep 1, 2015
samccone added a commit that referenced this issue Sep 12, 2015
DUEL: App Update (#1110), cancel editing on escape keypress (#789), and routing support (#812)
mhoyer pushed a commit to mhoyer/todomvc that referenced this issue Dec 5, 2015
podefr added a commit to podefr/todomvc that referenced this issue Jun 6, 2016
podefr added a commit to podefr/todomvc that referenced this issue Jun 6, 2016
podefr added a commit to podefr/todomvc that referenced this issue Jun 6, 2016
podefr added a commit to podefr/todomvc that referenced this issue Aug 9, 2016
podefr added a commit to podefr/todomvc that referenced this issue Aug 9, 2016
podefr added a commit to podefr/todomvc that referenced this issue Aug 9, 2016
podefr added a commit to podefr/todomvc that referenced this issue Aug 9, 2016
podefr added a commit to podefr/todomvc that referenced this issue Aug 9, 2016
@arthurvr arthurvr reopened this Nov 15, 2016
@arthurvr
Copy link
Member

This issue was closed by accident. PRs still welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants