Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routing should respect the back button #858

Open
6 of 11 tasks
ColinEberhardt opened this issue Feb 21, 2014 · 6 comments
Open
6 of 11 tasks

Routing should respect the back button #858

ColinEberhardt opened this issue Feb 21, 2014 · 6 comments
Labels
bug flight help wanted knockoutjs lavaca_require serenadejs spine

Comments

@ColinEberhardt
Copy link
Member

ColinEberhardt commented Feb 21, 2014 •
edited by arthurvr
Loading

A new test case was added in response to #856

Failures against the 'Routing, should respect the back button' test:

  • knockoutjs
  • vue.js
  • spine
  • componentjs
  • react
  • serenadejs
  • somajs
  • flight
  • lavaca_require
  • somajs_require
  • polymer
@ColinEberhardt
Copy link
Member Author

This issue is based on the following test results - removing failures for frameworks that do not implement routing, or suffer from #790

$ mocha allTests.js  --reporter list  --grep 'back button'

1) TodoMVC - agilityjs Routing should respect the back button
․ TodoMVC - angularjs Routing should respect the back button: 1328ms
․ TodoMVC - angularjs-perf Routing should respect the back button: 1338ms
2) TodoMVC - backbone Routing should respect the back button
․ TodoMVC - canjs Routing should respect the back button: 1195ms
․ TodoMVC - closure Routing should respect the back button: 1131ms
3) TodoMVC - dojo Routing should respect the back button
․ TodoMVC - emberjs Routing should respect the back button: 1467ms
․ TodoMVC - jquery Routing should respect the back button: 1136ms
․ TodoMVC - knockback Routing should respect the back button: 1113ms
4) TodoMVC - knockoutjs Routing should respect the back button
5) TodoMVC - maria Routing should respect the back button
․ TodoMVC - react Routing should respect the back button: 1231ms
6) TodoMVC - spine Routing should respect the back button
7) TodoMVC - angular-dart Routing should respect the back button
8) TodoMVC - ariatemplates Routing should respect the back button
9) TodoMVC - atmajs Routing should respect the back button
10) TodoMVC - backbone_marionette Routing should respect the back button
․ TodoMVC - batman Routing should respect the back button: 1353ms
11) TodoMVC - componentjs Routing should respect the back button
12) TodoMVC - dijon Routing should respect the back button
13) TodoMVC - duel Routing should respect the back button
․ TodoMVC - epitome Routing should respect the back button: 1131ms
14) TodoMVC - exoskeleton Routing should respect the back button
15) TodoMVC - extjs Routing should respect the back button
16) TodoMVC - extjs_deftjs Routing should respect the back button
․ TodoMVC - kendo Routing should respect the back button: 1167ms
․ TodoMVC - mozart Routing should respect the back button: 1309ms
17) TodoMVC - olives Routing should respect the back button
․ TodoMVC - plastronjs Routing should respect the back button: 1270ms
․ TodoMVC - puremvc Routing should respect the back button: 1237ms
․ TodoMVC - ractive Routing should respect the back button: 1328ms
․ TodoMVC - rappidjs Routing should respect the back button: 1247ms
18) TodoMVC - react Routing should respect the back button
19) TodoMVC - serenadejs Routing should respect the back button
20) TodoMVC - somajs Routing should respect the back button
21) TodoMVC - stapes Routing should respect the back button
22) TodoMVC - thorax Routing should respect the back button
․ TodoMVC - typescript-angular Routing should respect the back button: 1198ms
23) TodoMVC - typescript-backbone Routing should respect the back button
24) TodoMVC - vue Routing should respect the back button
․ TodoMVC - angularjs_require Routing should respect the back button: 1175ms
25) TodoMVC - backbone_marionette_require Routing should respect the back button
․ TodoMVC - canjs_require Routing should respect the back button: 1541ms
26) TodoMVC - chaplin-brunch Routing should respect the back button
27) TodoMVC - durandal Routing should respect the back button
․ TodoMVC - enyo_backbone Routing should respect the back button: 1651ms
28) TodoMVC - flight Routing should respect the back button
29) TodoMVC - knockoutjs_require Routing should respect the back button
30) TodoMVC - lavaca_require Routing should respect the back button
31) TodoMVC - somajs_require Routing should respect the back button
32) TodoMVC - stapes_require Routing should respect the back button
33) TodoMVC - thorax_lumbar Routing should respect the back button
34) TodoMVC - troopjs_require Routing should respect the back button
35) TodoMVC - backbone_require Routing should respect the back button
36) TodoMVC - flight Routing should respect the back button

20 passing (3m)
36 failing

This was referenced Feb 21, 2014
Closed
Merged
@soundstep
Copy link
Contributor

I've sent a pull request to solve the soma.js escape handling:

#901

I've also solved the back button problem.

Cheers.

@ColinEberhardt
Copy link
Member Author

@soundstep thanks for these fixes. I have updated the issues to give you a big tick :-)

@soundstep
Copy link
Contributor

@ColinEberhardt Amazing, thanks ;)

@ColinEberhardt ColinEberhardt mentioned this issue Jul 18, 2014
Closed
ColinEberhardt added a commit that referenced this issue Jul 18, 2014
@ColinEberhardt @sindresorhus
Close GH-951:
ca90e8c 
Browser tests no longer mandate hidden items are removed from the DOM

Fixes #908 - tests no longer mandate hidden items are removed from the DOM
Closes #790 - these were implementations that implemented routing via hiding items, rather than removing from the DOM

Regressions:
#949 - discovered that exoskeleton is badly broken
#858 - added typescript-backbone (might not be a regression, more likely missed earlier)

Updated knownIssues based on recent updates to puremvc, react, soma etc ...
@sindresorhus sindresorhus reopened this Jul 18, 2014
@arthurvr
Copy link
Member

polymer

We don't run de tests against polymer, and manually this worked fine for me.

@arthurvr arthurvr removed the polymer label Apr 25, 2015
@arthurvr
Copy link
Member

typescript-backbone

Removed this one from the list as it doesn't implement routing at all (where #812 (comment) is about)

@dmethvin dmethvin mentioned this issue Dec 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug flight help wanted knockoutjs lavaca_require serenadejs spine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@soundstep @sindresorhus @ColinEberhardt @arthurvr