Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Add HNPWA entry using Polymer Starter Kit #55

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions site/_apps/hn-pwa.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
weight: 9
title: 'HN-PWA'
github-title: 'mozeal'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the github title of the app, mozeal/hn-pwa, not just your username (Apologies if it's ambiguous!)

libraries:
- name: 'Polymer'
scaffolding: 'Polymer CLI & Polymer Starter Kit'
module-bundling: 'Polymer-build with HTML Imports'
service-worker: 'Application Shell + data caching with sw-precache'
perfomance-patterns: 'PRPL, code-splitting for granular loading'
server-side-rendering: 'None'
api: 'Node-hnapi (unofficial)'
hosting: 'Google AppEngine'
other-details: ''
authors:
- name: 'Mozeal'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in order for the contributor to show up underneath their app, you'll need to make sure the name here matches that in the contributor submission (for example if you wanted to use the name Mozeal, you'll have to put that exact string here and in your submission under _contributors

lighthouse: 91/100
interactive-em: 4.817s
interactive-faster-3g: 2.696s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both EMand 3G - I notice you obtained them from WPT First View times. We've been using the First Interactive (beta) times from the linked lighthouse results for each implementation so could you use that instead? (Looks like your 3G TTI is under 5s which is good 👍 )

lighthouse-link: https://www.webpagetest.org/lighthouse.php?test=170603_Q7_8f9c820981695c6b9fcc810c854b4362&run=3
wpt-em-link: https://www.webpagetest.org/result/170603_Q7_8f9c820981695c6b9fcc810c854b4362/
wpt-faster-3g-link: https://www.webpagetest.org/result/170603_8G_7c8f401cd68ccf076e1c2e00147c98a4/
image: http://qrx.io/ss/hn-pwa.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the rest of the implementations have been using a phone frame for each of the screenshots. What I used was MockUPhone to get any phone frame and just upload the image there (you may need to compress the output as well with something like Compressor.io as the images do come out quite large)

However we do need to change things up a bit and use either a single phone frame or a generic outline (#14) but until then this will work. I can later update all the phone frames when I get the time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing is that we host all the images in our site which makes for easier service worker caching. Could you just save the image in the assets/images directory to make things simpler here?

app-link: https://hn-pwa.appspot.com/
github-link: https://github.com/mozeal/hn-pwa
framework-link: https://www.polymer-project.org
---