Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace Cartridge CLI with tt CLI #780

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

p7nov
Copy link
Contributor

@p7nov p7nov commented Sep 18, 2023

Add deprecation note on main doc page
Provide instructions on migration to tt CLI

I didn't forget about

  • Tests - no test: documentation update
  • Changelog - no changelog: documentation update
  • Documentation - doc update

Part of tarantool/doc#3501

@LeonidVas LeonidVas self-requested a review September 18, 2023 10:46
doc/migration-to-tt.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@psergee psergee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Just a minor comment regarding status format.

Copy link
Collaborator

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the patch.
I think that in README.md also needs to add a corresponding note about product deprecation.

Migration from Cartridge CLI to tt
==================================

To switch from Cartridge CLI to ``tt``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean instead of this instruction or in addition?
We should have migration instructions published in Tarantool docs, so I wouldn't leave only the link to GitHub.

Add deprecation note
Provide migration instructions
@LeonidVas LeonidVas merged commit 4d07a8f into tarantool:master Sep 21, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants