Carry precompiled templates from notification pipeline #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xla
force-pushed
the
localised-notifications
branch
3 times, most recently
from
9ef425c to
32bf24f
Compare
To finally support all the local notifications we need a way to send the configured template per language in the actual notification. This change compiles all templates for all messages before returning it as part of a map from the pipeline. This could certainly be improved to not do unnecessary work but would need that the channel which has the device knowledge has to know about the templates, either way could be wasteful. For now we trade cpu time for complexity.
xla
force-pushed
the
localised-notifications
branch
from
32bf24f to
e9240be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To finally support all the local notifications we need a way to send the configured template per language in the actual notification. This change compiles all templates for all messages before returning it as part of a map from the pipeline. This could certainly be improved to not do unnecessary work but would need that the channel which has the device knowledge has to know about the templates, either way could be wasteful. For now we trade cpu time for complexity.