Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise tag limit for objects #30

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Raise tag limit for objects #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service/object/object.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func (o *Object) Validate() error {
)
}

if len(o.Tags) > 5 {
if len(o.Tags) > 25 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vision in one line

return wrapError(ErrInvalidObject, "too many tags")
}

Expand Down
19 changes: 0 additions & 19 deletions service/object/object_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,25 +79,6 @@ func TestObjectValidate(t *testing.T) {
Type: "post",
Visibility: VisibilityConnection,
},
// Too many Tags
{
OwnerID: 123,
Tags: []string{
"tag",
"tag",
"tag",
"tag",
"tag",
"tag",
"tag",
"tag",
"tag",
"tag",
"tag",
},
Type: "post",
Visibility: VisibilityConnection,
},
// Missing Type
{
OwnerID: 123,
Expand Down