-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This adds a simple way to have namespaced counters per user and get the global count per namespace. In essence this can be used for a variety of use-cases, e.g. leaderboards, group challenges, etc. Introducing only the barest of functionality it will be extended as use-cases arise and applications have been identified. A variety of dimensions might be added for future extension to have contextual leadboards, for example slicing by location, user core data or free form tags. Counter payload: ``` { "value": 123 } ``` In the first iteration we support two endpoints: * `PUT /me/counters/<counterName>`: Expects the counter payload and sets the named counter for the current user to the given value. * `GET /counters/<counterName>`: Returns the sum of all values for all users for the named counter.
- Loading branch information
Alexander Simmerl
committed
Jul 18, 2017
1 parent
5fce8cb
commit c3ecba3
Showing
7 changed files
with
446 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package core | ||
|
||
import ( | ||
"github.com/tapglue/snaas/service/app" | ||
"github.com/tapglue/snaas/service/counter" | ||
) | ||
|
||
// CounterGetAllFunc returns the sum of all counter for a coutner name. | ||
type CounterGetAllFunc func(currentApp *app.App, name string) (uint64, error) | ||
|
||
// CounterGetAll returns the sum of all counter for a coutner name. | ||
func CounterGetAll(counters counter.Service) CounterGetAllFunc { | ||
return func(currentApp *app.App, name string) (uint64, error) { | ||
return counters.CountAll(currentApp.Namespace(), name) | ||
} | ||
} | ||
|
||
// CounterSetFunc sets the counter for the current user and the given counter | ||
// name to the new value. | ||
type CounterSetFunc func( | ||
currentApp *app.App, | ||
origin uint64, | ||
name string, | ||
value uint64, | ||
) error | ||
|
||
// CounterSet sets the counter for the current user and the given counter name | ||
// to the new value. | ||
func CounterSet(counters counter.Service) CounterSetFunc { | ||
return func( | ||
currentApp *app.App, | ||
origin uint64, | ||
name string, | ||
value uint64, | ||
) error { | ||
return counters.Set(currentApp.Namespace(), name, origin, value) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
package http | ||
|
||
import ( | ||
"encoding/json" | ||
"net/http" | ||
|
||
"golang.org/x/net/context" | ||
|
||
"github.com/tapglue/snaas/core" | ||
) | ||
|
||
// CounterGetAll returns the sum of all counter for a coutner name. | ||
func CounterGetAll(fn core.CounterGetAllFunc) Handler { | ||
return func(ctx context.Context, w http.ResponseWriter, r *http.Request) { | ||
var ( | ||
currentApp = appFromContext(ctx) | ||
) | ||
|
||
name, err := extractCounterName(r) | ||
if err != nil { | ||
respondError(w, 0, wrapError(ErrBadRequest, err.Error())) | ||
return | ||
} | ||
|
||
v, err := fn(currentApp, name) | ||
if err != nil { | ||
respondError(w, 0, err) | ||
return | ||
} | ||
|
||
respondJSON(w, http.StatusOK, &payloadCounter{Value: v}) | ||
} | ||
} | ||
|
||
// CounterSet sets the counter for the current user and the given counter name | ||
// to the new value. | ||
func CounterSet(fn core.CounterSetFunc) Handler { | ||
return func(ctx context.Context, w http.ResponseWriter, r *http.Request) { | ||
var ( | ||
currentApp = appFromContext(ctx) | ||
currentUser = userFromContext(ctx) | ||
p = payloadCounter{} | ||
) | ||
|
||
name, err := extractCounterName(r) | ||
if err != nil { | ||
respondError(w, 0, wrapError(ErrBadRequest, err.Error())) | ||
return | ||
} | ||
|
||
err = json.NewDecoder(r.Body).Decode(&p) | ||
if err != nil { | ||
respondError(w, 0, wrapError(ErrBadRequest, err.Error())) | ||
return | ||
} | ||
|
||
err = fn(currentApp, currentUser.ID, name, p.Value) | ||
if err != nil { | ||
respondError(w, 0, err) | ||
return | ||
} | ||
|
||
respondJSON(w, http.StatusNoContent, nil) | ||
} | ||
} | ||
|
||
type payloadCounter struct { | ||
Value uint64 `json:"value"` | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package counter | ||
|
||
import ( | ||
"github.com/tapglue/snaas/platform/service" | ||
) | ||
|
||
// Service for counter interactions. | ||
type Service interface { | ||
service.Lifecycle | ||
|
||
Count(namespace, name string, userID uint64) (uint64, error) | ||
CountAll(namespace, name string) (uint64, error) | ||
Set(namespace, name string, userID, value uint64) error | ||
} | ||
|
||
// ServiceMiddleware is a chainable behaviour modifier for Service. | ||
type ServiceMiddleware func(Service) Service |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,195 @@ | ||
package counter | ||
|
||
import ( | ||
"fmt" | ||
|
||
"github.com/tapglue/snaas/platform/pg" | ||
|
||
"github.com/jmoiron/sqlx" | ||
) | ||
|
||
const ( | ||
pgGetCounter = ` | ||
SELECT | ||
value | ||
FROM | ||
%s.counters | ||
WHERE | ||
deleted = false | ||
AND name = $1 | ||
ANd user_id = $2 | ||
LIMIT | ||
1` | ||
pgGetCounterAll = ` | ||
SELECT | ||
sum(value) | ||
FROM | ||
%s.counters | ||
WHERE | ||
deleted = false | ||
AND name = $1` | ||
pgSetCounter = ` | ||
INSERT INTO %s.counters(name, user_id, value) | ||
VALUES($1, $2, $3) | ||
ON CONFLICT (name, user_id) DO | ||
UPDATE SET | ||
value = $3` | ||
|
||
pgCreateSchema = `CREATE SCHEMA IF NOT EXISTS %s` | ||
pgCreateTable = ` | ||
CREATE TABLE IF NOT EXISTS %s.counters( | ||
name TEXT NOT NULL, | ||
user_id BIGINT NOT NULL, | ||
value BIGINT NOT NULL, | ||
deleted BOOL DEFAULT false, | ||
created_at TIMESTAMP WITHOUT TIME ZONE DEFAULT (now() AT TIME ZONE 'utc'), | ||
updated_at TIMESTAMP WITHOUT TIME ZONE DEFAULT (now() AT TIME ZONE 'utc'), | ||
CONSTRAINT counter_id UNIQUE (name, user_id), | ||
PRIMARY KEY (name, user_id) | ||
)` | ||
pgDropTable = `DROP TABLE IF EXISTS %s.counters CASCADE` | ||
|
||
pgIndexCounterID = ` | ||
CREATE UNIQUE INDEX | ||
%s | ||
ON | ||
%s.counters | ||
USING | ||
btree(name, user_id)` | ||
pgIndexCounterName = ` | ||
CREATE INDEX | ||
%s | ||
ON | ||
%s.counters | ||
USING | ||
btree(name)` | ||
|
||
// Extensions. | ||
pgCreateExtensionModdatetime = `CREATE EXTENSION IF NOT EXISTS moddatetime` | ||
|
||
// Trigger to autoamtically set the latest time on updated_at, depends on | ||
// the moddatetime extension: | ||
// * https://www.postgresql.org/docs/current/static/contrib-spi.html | ||
// * https://github.com/postgres/postgres/blob/master/contrib/spi/moddatetime.example | ||
// * https://dba.stackexchange.com/a/158750 | ||
pgAlterTriggerUpdatedAt = ` | ||
ALTER TRIGGER %s ON %s.counters DEPENDS ON EXTENSION moddatetime` | ||
pgCreateTriggerUpdatedAt = ` | ||
CREATE TRIGGER | ||
%s | ||
BEFORE UPDATE ON | ||
%s.counters | ||
FOR EACH ROW EXECUTE PROCEDURE | ||
moddatetime(updated_at)` | ||
pgDropTriggerUpdatedAt = ` | ||
DROP TRIGGER IF EXISTS %s ON %s.counters` | ||
) | ||
|
||
type pgService struct { | ||
db *sqlx.DB | ||
} | ||
|
||
func PostgresService(db *sqlx.DB) Service { | ||
return &pgService{db: db} | ||
} | ||
|
||
func (s *pgService) Count(ns, name string, userID uint64) (uint64, error) { | ||
var ( | ||
args = []interface{}{name, userID} | ||
query = fmt.Sprintf(pgGetCounter, ns) | ||
|
||
value uint64 | ||
) | ||
|
||
err := s.db.Get(&value, query, args...) | ||
if err != nil && pg.IsRelationNotFound(pg.WrapError(err)) { | ||
if err := s.Setup(ns); err != nil { | ||
return 0, err | ||
} | ||
|
||
err = s.db.Get(&value, query, args...) | ||
} | ||
|
||
return value, err | ||
} | ||
|
||
func (s *pgService) CountAll(ns, name string) (uint64, error) { | ||
var ( | ||
args = []interface{}{name} | ||
query = fmt.Sprintf(pgGetCounterAll, ns) | ||
|
||
value uint64 | ||
) | ||
|
||
err := s.db.Get(&value, query, args...) | ||
if err != nil && pg.IsRelationNotFound(pg.WrapError(err)) { | ||
if err := s.Setup(ns); err != nil { | ||
return 0, err | ||
} | ||
|
||
err = s.db.Get(&value, query, args...) | ||
} | ||
|
||
return value, err | ||
} | ||
|
||
func (s *pgService) Set(ns, name string, userID, value uint64) error { | ||
var ( | ||
args = []interface{}{ | ||
name, | ||
userID, | ||
value, | ||
} | ||
query = fmt.Sprintf(pgSetCounter, ns) | ||
) | ||
|
||
_, err := s.db.Exec(query, args...) | ||
if err != nil && pg.IsRelationNotFound(pg.WrapError(err)) { | ||
if err := s.Setup(ns); err != nil { | ||
return err | ||
} | ||
|
||
_, err = s.db.Exec(query, args...) | ||
} | ||
|
||
return err | ||
} | ||
|
||
func (s *pgService) Setup(ns string) error { | ||
for _, q := range []string{ | ||
fmt.Sprintf(pgCreateSchema, ns), | ||
fmt.Sprintf(pgCreateTable, ns), | ||
|
||
// Indexes. | ||
pg.GuardIndex(ns, "counter_counter_id", pgIndexCounterID), | ||
pg.GuardIndex(ns, "counter_counter_name", pgIndexCounterName), | ||
|
||
// FIXME: Re-enable when migrated to Postgres 9.6 | ||
// Setup idempotent updated_at trigger. | ||
// pgCreateExtensionModdatetime, | ||
// fmt.Sprintf(pgDropTriggerUpdatedAt, "counter_updated_at", ns), | ||
// fmt.Sprintf(pgCreateTriggerUpdatedAt, "counter_updated_at", ns), | ||
// fmt.Sprintf(pgAlterTriggerUpdatedAt, "counter_updated_at", ns), | ||
} { | ||
_, err := s.db.Exec(q) | ||
if err != nil { | ||
return fmt.Errorf("setup '%s': %s", q, err) | ||
} | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func (s *pgService) Teardown(ns string) error { | ||
for _, q := range []string{ | ||
fmt.Sprintf(pgDropTable, ns), | ||
} { | ||
_, err := s.db.Exec(q) | ||
if err != nil { | ||
return fmt.Errorf("teardown '%s': %s", q, err) | ||
} | ||
} | ||
|
||
return nil | ||
} |
Oops, something went wrong.