fixup! Extract AtSuggestionCompleter

src/providers/atsuggestion.ts

@@ -0,0 +1,44 @@
+import * as vscode from 'vscode'
+
+import {AtSuggestion} from './atsuggestionlib/atsuggestion'
+import {escapeRegExp} from '../utils/utils'
+
+export class AtSuggestionCompleter implements vscode.CompletionItemProvider {
+    private readonly atSuggestion: AtSuggestion
+    private readonly triggerCharacter: string
+
+    constructor(
+        extension: {
+            readonly extensionRoot: string
+        },
+        triggerCharacter: string
+    ) {
+        this.atSuggestion = new AtSuggestion(extension, triggerCharacter)
+        this.triggerCharacter = triggerCharacter
+    }
+
+    get readyPromise() {
+        return this.atSuggestion.readyPromise
+    }
+
+    provideCompletionItems(
+        document: vscode.TextDocument,
+        position: vscode.Position,
+        token: vscode.CancellationToken,
+        context: vscode.CompletionContext
+    ): vscode.CompletionItem[] | undefined {
+        const line = document.lineAt(position).text.substring(0, position.character)
+        return this.completion(line, {document, position, token, context})
+    }
+
+    private completion(line: string, args: {document: vscode.TextDocument, position: vscode.Position, token: vscode.CancellationToken, context: vscode.CompletionContext}): vscode.CompletionItem[] {
+        const escapedTriggerCharacter = escapeRegExp(this.triggerCharacter)
+        const reg = new RegExp(escapedTriggerCharacter + '[^\\\\s]*$')
+        const result = line.match(reg)
+        let suggestions: vscode.CompletionItem[] = []
+        if (result) {
+            suggestions = this.atSuggestion.provideFrom(result, args)
+        }
+        return suggestions
+    }
+}

src/providers/completer/atsuggestion.ts → src/providers/atsuggestionlib/atsuggestion.ts

@@ -1,9 +1,9 @@
 import * as vscode from 'vscode'
 
-import type {IProvider} from './interface'
+import type {IProvider} from '../completer/interface'
 import {escapeRegExp} from '../../utils/utils'
 import { readFilePath } from '../../lib/lwfs/lwfs'
-import { CommandKind } from './completionkind'
+import { CommandKind } from '../completer/completionkind'
 
 
 export interface AtSuggestionItemEntry {

src/providers/completion.ts

@@ -8,12 +8,10 @@ import {Command} from './completer/command'
 import type {CmdItemEntry} from './completer/command'
 import {Environment} from './completer/environment'
 import type {EnvItemEntry} from './completer/environment'
-import {AtSuggestion} from './completer/atsuggestion'
 import {LabelDefinition} from './completer/labeldefinition'
 import {Package} from './completer/package'
 import {Input, Import, SubImport} from './completer/input'
 import {Glossary} from './completer/glossary'
-import {escapeRegExp} from '../utils/utils'
 import { readFilePath } from '../lib/lwfs/lwfs'
 import { BracketReplacer } from './completer/bracketreplacer'
 import { CommandRemover } from './completer/commandremover'
@@ -272,42 +270,4 @@ export class Completer implements vscode.CompletionItemProvider {
     }
 }
 
-export class AtSuggestionCompleter implements vscode.CompletionItemProvider {
-    private readonly atSuggestion: AtSuggestion
-    private readonly triggerCharacter: string
 
-    constructor(
-        extension: {
-            readonly extensionRoot: string
-        },
-        triggerCharacter: string
-    ) {
-        this.atSuggestion = new AtSuggestion(extension, triggerCharacter)
-        this.triggerCharacter = triggerCharacter
-    }
-
-    get readyPromise() {
-        return this.atSuggestion.readyPromise
-    }
-
-    provideCompletionItems(
-        document: vscode.TextDocument,
-        position: vscode.Position,
-        token: vscode.CancellationToken,
-        context: vscode.CompletionContext
-    ): vscode.CompletionItem[] | undefined {
-        const line = document.lineAt(position).text.substring(0, position.character)
-        return this.completion(line, {document, position, token, context})
-    }
-
-    private completion(line: string, args: {document: vscode.TextDocument, position: vscode.Position, token: vscode.CancellationToken, context: vscode.CompletionContext}): vscode.CompletionItem[] {
-        const escapedTriggerCharacter = escapeRegExp(this.triggerCharacter)
-        const reg = new RegExp(escapedTriggerCharacter + '[^\\\\s]*$')
-        const result = line.match(reg)
-        let suggestions: vscode.CompletionItem[] = []
-        if (result) {
-            suggestions = this.atSuggestion.provideFrom(result, args)
-        }
-        return suggestions
-    }
-}

src/providersmanager.ts

@@ -13,7 +13,7 @@ import { FoldingProvider } from './providers/folding'
 import { BibtexFormatterProvider } from './providers/bibtexformatter'
 import type { Extension } from './main'
 import { MathPreviewPanelSerializer } from './components/mathpreviewpanel'
-import { AtSuggestionCompleter } from './providers/completion'
+import { AtSuggestionCompleter } from './providers/atsuggestion'
 
 
 abstract class SingleProviderManager implements vscode.Disposable {

test/completion.test.ts

@@ -9,6 +9,7 @@ import {
     runTestWithFixture,
     sleep
 } from './utils/ciutils'
+import { AtSuggestionCompleter } from '../src/providers/atsuggestion'
 
 
 function assertCompletionItemContainsSnippet(items: vscode.CompletionItem[], prefix: string, snippet: string): void {
@@ -78,7 +79,9 @@ suite('Completion test suite', () => {
         await sleep(1000)
         const pos = new vscode.Position(3,1)
         const token = new vscode.CancellationTokenSource().token
-        const items = extension.exports.realExtension.completer.atSuggestionCompleter.provideCompletionItems(
+        const atSuggestionCompleter = new AtSuggestionCompleter(extension.exports.realExtension, '@')
+        await atSuggestionCompleter.readyPromise
+        const items = atSuggestionCompleter.provideCompletionItems(
             doc, pos, token,
             {
                 triggerKind: vscode.CompletionTriggerKind.Invoke,
@@ -104,7 +107,9 @@ suite('Completion test suite', () => {
         await sleep(1000)
         const pos = new vscode.Position(3,1)
         const token = new vscode.CancellationTokenSource().token
-        const items = extension.exports.realExtension.completer.atSuggestionCompleter.provideCompletionItems(
+        const atSuggestionCompleter = new AtSuggestionCompleter(extension.exports.realExtension, '@')
+        await atSuggestionCompleter.readyPromise
+        const items = atSuggestionCompleter.provideCompletionItems(
             doc, pos, token,
             {
                 triggerKind: vscode.CompletionTriggerKind.Invoke,