Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactoring development code #100

Merged
merged 12 commits into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
path: '**/node_modules'
key: ${{ runner.os }}-pnpm-store-${{ needs.init.outputs.cache-name }}-${{ hashFiles('**/pnpm-lock.yaml') }}
- name: Type check
run: pnpm vsm gen:unimport-type && pnpm vsm lint:type-check
run: pnpm vsm lint:type-check

eslint-check:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
path: '**/node_modules'
key: ${{ runner.os }}-pnpm-store-${{ needs.init.outputs.cache-name }}-${{ hashFiles('**/pnpm-lock.yaml') }}
- name: Build check
run: pnpm vsm gen:unimport-type && pnpm vsm build
run: pnpm vsm build

publish-check:
runs-on: ubuntu-latest
Expand All @@ -129,6 +129,6 @@ jobs:
path: '**/node_modules'
key: ${{ runner.os }}-pnpm-store-${{ needs.init.outputs.cache-name }}-${{ hashFiles('**/pnpm-lock.yaml') }}
- name: Build check
run: pnpm vsm gen:unimport-type && pnpm vsm build
run: pnpm vsm build
- name: Publish check
run: pnpm vsm publish --dry-run --no-git-checks
2 changes: 1 addition & 1 deletion demo/vue/src/App.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script setup lang="ts">
import { ref, computed } from "vue";
import { SwipeModal } from "@takuma-ru/vue-swipe-modal";
import { SwipeModal } from "@takuma-ru/vue-swipe-modal"

const isOpen = ref(false);

Expand Down
15 changes: 0 additions & 15 deletions packages/core/.eslintrc.yml

This file was deleted.

1 change: 0 additions & 1 deletion packages/core/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@ dist-ssr
*.sw?

# .d.ts
unimport.d.ts
6 changes: 0 additions & 6 deletions packages/core/.prettierrc.yml

This file was deleted.

19 changes: 0 additions & 19 deletions packages/core/.scripts/genUnimportType.js

This file was deleted.

28 changes: 14 additions & 14 deletions packages/core/.stylelintrc.json
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"extends": [
"stylelint-rscss/config",
"stylelint-config-standard-scss",
"stylelint-config-recess-order",
"stylelint-prettier/recommended",
"stylelint-config-recommended-vue/scss"
],
"rules": {
"string-quotes": "double",
"property-no-vendor-prefix": [
true,
{ "ignoreProperties": ["backdrop-filter"] }
]
}
"extends": [
"stylelint-rscss/config",
"stylelint-config-standard-scss",
"stylelint-config-recess-order",
"stylelint-prettier/recommended",
"stylelint-config-recommended-vue/scss"
],
"rules": {
"string-quotes": "double",
"property-no-vendor-prefix": [
true,
{ "ignoreProperties": ["backdrop-filter"] }
]
}
}
2 changes: 1 addition & 1 deletion packages/core/.vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"recommendations": ["Vue.volar", "Vue.vscode-typescript-vue-plugin"]
"recommendations": ["Vue.volar", "Vue.vscode-typescript-vue-plugin"]
}
64 changes: 54 additions & 10 deletions packages/core/.vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,56 @@
{
"editor.formatOnSave": true, // ファイル保存時に自動整形を行うようにする
"editor.defaultFormatter": "esbenp.prettier-vscode", // デフォルトのフォーマッターを「prettier」にする
"editor.tabSize": 2, // タブサイズを半角スペース二つにする
"editor.codeActionsOnSave": {
"source.fixAll.stylelint": "explicit",
"source.addMissingImports": "explicit"
},
"stylelint.validate": ["css", "scss", "vue"], // stylelintの自動整形の対象ファイルを設定を行うようにする
"files.eol": "\n", // 改行コードを指定
"cSpell.words": ["consola", "Unimport"]
// Enable the ESlint flat config support
"eslint.experimental.useFlatConfig": true,

// Disable the default formatter, use eslint instead
"prettier.enable": false,
"css.validate": false,
"less.validate": false,
"scss.validate": false,

"editor.tabSize": 2,
"editor.formatOnSave": false,
"files.eol": "\n",
"typescript.preferences.importModuleSpecifier": "non-relative",

// Auto fix
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit",
"source.fixAll.stylelint": "explicit",
"source.organizeImports": "never",
"source.addMissingImports": "explicit"
},

// Silent the stylistic rules in you IDE, but still auto fix them
"eslint.rules.customizations": [
{ "rule": "style/*", "severity": "off" },
{ "rule": "format/*", "severity": "off" },
{ "rule": "*-indent", "severity": "off" },
{ "rule": "*-spacing", "severity": "off" },
{ "rule": "*-spaces", "severity": "off" },
{ "rule": "*-order", "severity": "off" },
{ "rule": "*-dangle", "severity": "off" },
{ "rule": "*-newline", "severity": "off" },
{ "rule": "*quotes", "severity": "off" },
{ "rule": "*semi", "severity": "default" }
],

// Enable eslint for all supported languages
"eslint.validate": [
"javascript",
"javascriptreact",
"typescript",
"typescriptreact",
"vue",
"html",
"markdown",
"json",
"jsonc",
"yaml",
"toml",
"gql",
"graphql"
],

"stylelint.validate": ["css", "vue"]
}
3 changes: 0 additions & 3 deletions packages/core/@types/App.vue.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/core/@types/App.vue.d.ts.map

This file was deleted.

103 changes: 0 additions & 103 deletions packages/core/@types/components/SwipeModal.vue.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/core/@types/components/SwipeModal.vue.d.ts.map

This file was deleted.

2 changes: 0 additions & 2 deletions packages/core/@types/dev-main.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/core/@types/dev-main.d.ts.map

This file was deleted.

3 changes: 0 additions & 3 deletions packages/core/@types/dev/App.vue.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/core/@types/dev/App.vue.d.ts.map

This file was deleted.

2 changes: 0 additions & 2 deletions packages/core/@types/dev/main.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/core/@types/dev/main.d.ts.map

This file was deleted.

4 changes: 0 additions & 4 deletions packages/core/@types/main.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/core/@types/main.d.ts.map

This file was deleted.

Loading
Loading