Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visual jitter in Combobox component when using native scrollbar #3190

Merged

Commits on May 28, 2024

  1. Configuration menu
    Copy the full SHA
    daf69a1 View commit details
    Browse the repository at this point in the history
  2. format comment

    RobinMalfait committed May 28, 2024
    Configuration menu
    Copy the full SHA
    779768d View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. set ActivationTrigger in mousedown

    If you use the scrollbar, a `mousedown` and `pointerdown` event is fired
    before you start interacting with the scrollbar. If you use the `scroll`
    event, then the callback is fired while scrolling.
    
    To improve performance a bit more, we will set the activation trigger in
    the `mousedown` event because we only need to set it once.
    
    If you are done scrolling, we don't reset it (we didn't do that before
    either), but instead we rely on other events to override the trigger
    (e.g.: you start using the keyboard).
    
    The big benefit is that this now only calls the `setActivationTrigger`
    once, instead of `n` times with the same value.
    RobinMalfait committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2f9aeb3 View commit details
    Browse the repository at this point in the history
  2. optimize onWheel to only trigger once

    This is a similar performance trick as before. We only need to set the
    activationTrigger once, so there is no need to keep calling this
    function for no reason.
    RobinMalfait committed May 29, 2024
    Configuration menu
    Copy the full SHA
    4e34771 View commit details
    Browse the repository at this point in the history
  3. update changelog

    RobinMalfait committed May 29, 2024
    Configuration menu
    Copy the full SHA
    8c53bc1 View commit details
    Browse the repository at this point in the history