Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure DOM ref is properly handled in the RadioGroup component #2424

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Ensure DOM ref is properly handled in the RadioGroup component #2424

merged 4 commits into from
Apr 11, 2023

Commits on Apr 11, 2023

  1. drop by prop 

    Otherwise it ends up in the DOM which doesn't hurt but isn't ideal
either.
    @RobinMalfait
    RobinMalfait committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d58ac56 View commit details
    Browse the repository at this point in the history

  2. ensure we are reading the underlying DOM correctly 

    We assumed that the `optionRef` was `HTMLElement | null`, but if you use
a custom component, then it is exposed as `{ $el: ref }`, this is why we
use the `dom()` helper.
    @RobinMalfait
    RobinMalfait committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    608733a View commit details
    Browse the repository at this point in the history

  3. add test to ensure using a custom as prop works as expected

    @RobinMalfait
    RobinMalfait committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c51b114 View commit details
    Browse the repository at this point in the history

  4. update changelog

    @RobinMalfait
    RobinMalfait committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5373779 View commit details
    Browse the repository at this point in the history