tsnet,wgengine/netstack: add ListenPacket #12184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maisem
force-pushed
the
maisem/tsnet-udp
branch
3 times, most recently
from
f72de82
to
da82771
Compare
willnorris
reviewed
May 18, 2024
willnorris
reviewed
May 19, 2024
willnorris
approved these changes
May 20, 2024
|
Okay, I got this working: % /opt/homebrew/opt/curl/bin/curl -i --http3 https://caddytest.tailb575b.ts.net/
HTTP/3 200
date: Tue, 21 May 2024 16:26:26 GMT
content-length: 2
server: Caddy
content-type: text/plain; charset=utf-8
OKI think the issues I had yesterday were more to do with my browser. Once I got a version of curl compiled with QUIC support, this packet listener seems to work as expected. |
maisem
force-pushed
the
maisem/tsnet-udp
branch
2 times, most recently
from
a7406a6
to
d8c0547
Compare
maisem
changed the title
willnorris
approved these changes
Jun 1, 2024
bradfitz
approved these changes
Jun 2, 2024
| @@ -908,6 +917,34 @@ func (s *Server) Listen(network, addr string) (net.Listener, error) { | |||
| return s.listen(network, addr, listenOnTailnet) | |||
| } | |||
|
|
|||
| // ListenPacket announces on the Tailscale network. | |||
There was a problem hiding this comment.
TIL that's exactly the wording the net package uses. okay then
This adds a new ListenPacket function on tsnet.Server which acts mostly like `net.ListenPacket`. Unlike `Server.Listen`, this requires listening on a specific IP and does not automatically listen on both V4 and V6 addresses of the Server when the IP is unspecified. To test this, it also adds UDP support to tsdial.Dialer.UserDial and plumbs it through the localapi. Then an associated test to make sure the UDP functionality works from both sides. Updates #12182 Signed-off-by: Maisem Ali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new ListenPacket function on tsnet.Server
which acts mostly like
net.ListenPacket.Unlike
Server.Listen, this requires listening on aspecific IP and does not automatically listen on both
V4 and V6 addresses of the Server when the IP is unspecified.
To test this, it also adds UDP support to tsdial.Dialer.UserDial
and plumbs it through the localapi. Then an associated test
to make sure the UDP functionality works from both sides.
Updates #12182