feat: error handling feature #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerLamTd
reviewed
May 6, 2024
RogerLamTd
reviewed
May 8, 2024
RogerLamTd
reviewed
May 8, 2024
|
@richardgreg lgtm, please resolve conflicts and should be good to merge! |
|
Done 🙂 |
|
Is it safe to assume this PR is no longer relevant? 😁 |
Sorry, been busy with other stuff; could you fix the conflicts and test the error handling locally perhaps? Just ensure that it functions as intended with docker :) |
flechemano
approved these changes
May 21, 2024
|
Give me a sec, I'll submit a fix before the end of the day 😄 |
Also added logic for retries before it completely fails
@richardgreg Could you test this and provide proof it works? Just a case where maybe a flag is misconfigured, show it retries and then exits after. Thanks! |
|
closing as stale, please feel free to reopen with changes/tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error-handling and retry logic to scripts
Closes #219