feat(node): allow uprotected txs flag for proxy deploy for devrel team

[cyberhorsey]

defaults to false if variable is not set

[davidtaikocha]

Since our node has enabled EIP-155 in genesis, emm not sure will this work? and whats the reason we want to allow unprotected txs?

[MarcusWentz]

@davidtaikocha

We are trying to deploy a deterministic proxy contract.

This method:
https://github.com/Arachnid/deterministic-deployment-proxy
requires us to send a signed transaction with RLP only valid before EIP-155.

Therefore, we need to set the following flag

rpc.allow-unprotected-txs=true

to allow the unprotected transaction to go through.

[davidtaikocha]

@davidtaikocha

We are trying to deploy a deterministic proxy contract.

This method: https://github.com/Arachnid/deterministic-deployment-proxy requires us to send a signed transaction with RLP only valid before EIP-155.

Therefore, we need to set the following flag

rpc.allow-unprotected-txs=true

to allow the unprotected transaction to go through.

emmm actually i don't think this deserves a PR to merge that flag config into our public repo. Looks like the reason why that script requires to send a signed transaction with RLP only valid before EIP-155 is because that script is too old (4 years ago) (correct me if i'm wrong)? Sending pre-EIP-155 txs with any private key has some potential security issues right? And nowadays nobody should do that. Like those transactions in our testnet can be re-played by others (not the original user) in mainnet. So updating the script to make it sending post-EIP-155 txs sounds like a more reasonable approach?

[MarcusWentz]

The RLP does not include EIP-155 intentionally here
https://github.com/Arachnid/deterministic-deployment-proxy
for it to be reused cross chain.

Can I use this branch as a reference to add this flag if we choose not to merge?

[davidtaikocha]

Updating the script to make it sending post-EIP-155 txs sounds like a more reasonable approach?

I still thinking this is the right way to do that? Sending an unprotected transaction in a EIP-155 enabled chain should be a very very unrecommended behavior and nobody should do that nowadays?

[davidtaikocha]

The RLP does not include EIP-155 intentionally here https://github.com/Arachnid/deterministic-deployment-proxy for it to be reused cross chain.

Can I use this branch as a reference to add this flag if we choose not to merge?

But if u think this deterministic-deployment-proxy is a necessary for u at current stage... u can add that flag in a branch but not merge it into main.

[davidtaikocha]

Close this one since we won't merge that flag config into main branch.

[cyberhorsey]

Close this one since we won't merge that flag config into main branch.

Yes this is just for devrel to use, apparently they need to not use EIP-155, they talked to the creators of the script and for some reason it can't function the same way without pre-EIP 155. So it's not intended for community use, or anyone besides Marcus really.