Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eldfell): fix --proveUnassignedBlocks flag setting #109

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix(eldfell): fix --proveUnassignedBlocks flag setting #109

merged 1 commit into from
Aug 4, 2023

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Aug 4, 2023 •
edited
Loading

When using --proveUnassignedBlocks false, golang cli will parse the flag value as true, we need to use --proveUnassignedBlocks=false

@davidtaikocha davidtaikocha enabled auto-merge (squash) August 4, 2023 15:35
@davidtaikocha davidtaikocha merged commit 0a86e18 into main Aug 4, 2023
3 checks passed
@davidtaikocha davidtaikocha deleted the fix-proveUnassignedBlocks-flag branch August 4, 2023 16:23
@github-actions github-actions bot mentioned this pull request Feb 12, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 21, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dionysuzx dionysuzx dionysuzx approved these changes

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

Assignees
No one assigned
Labels
meta.alpha-4 type.bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidtaikocha @dionysuzx