-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding helm chart to the repository #606
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @zer0stars! Thanks for doing this. @brunocalza can you give it a once over as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work @zer0stars ! I was able to deploy a validator using this chart.
In general, this PR looks good to me. I left some comments about changing ports and removing a webhook config.
helm/tableland/values.yaml
Outdated
"EventProcessor": { | ||
"BlockFailedExecutionBackoff": "10s", | ||
"DedupExecutedTxns": true, | ||
"WebhookURL": "https://discord.com/api/webhooks/${VALIDATOR_DISCORD_WEBHOOK_ID}/${VALIDATOR_DISCORD_WEBHOOK_TOKEN}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this config can be removed, this is more like an internal thing we have to notify us when a txn happens (note: it needs to be removed for every chain)
# Https port of the application | ||
httpsPort: 8443 | ||
# Metrics port of the application | ||
metricsPort: 8888 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default validator metrics port is 9090, if you change this to 9090, metrics can be accessed at :9000/metrics
if you change this, there's a change that needs to be made in the readme too
You can specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example, | ||
|
||
```shell | ||
helm install [release-name] [repo-name]/tableland-validator-node --set imagePullPolicy=Always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is /tableland-validator-node
?
Summary
Adding helm chart for running tableland validator in Kubernetes using helm.
Context
Enabling production setup for running a tableland node.
Implementation overview
Solves the problem of DIMO needing a helm chart to run in k8s.
Implementation details and review orientation
Checklist