URL Search Params for Players and History page #942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I checked out your dev notes and found the wouter and URL search params to-do entry, and I thought maybe I could do this. I'm sorry if I was supposed to contact you about this before starting, but giving the feature was pretty simple to implement I figured that I could just make a PR and see if you liked it or not.
The URL parameters will update when the state changes in the component. If this is not the expected behavior and you wanted it to be a copy URL button instead, I could change the code around.
I also removed the export on the
throttleFunc
in both files. Vite HMR won't complain if the export is removed. HMR is also fully functional without the export.Video showcasing the feature.
brave_HHb5waBgkH.mp4