[fix] Fix Apple login callbacks not redirecting back to the App for Expo #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garshythoel
changed the title
garshythoel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the repo doesn't work for Sign in with Apple mainly because apple sends a POST request for the callback as opposed to a GET request.
Current Behavior
When signing in on an expo app with Apple, the website login happen in the auth-browser but does not actually exit out and redirect to the app. Because of this the token is not set on the app either.
Apple sends the
/callbackrequest as a POST rather than a GET. In this change we create an expo callback handler function and use that in both the GET and POST request handlers.New Behavior
The website login takes place in the Auth browser and redirects to the app - setting the session token correctly.