Add derive feature and change file structure #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing...
Going to make this look a lot like serde and prepare to add that derive feature.
I don't know if this works
Should? Output the macros now.
alright this SHOULD work
Should export to the same location as WrapperApi is taken. So you don't need to use from the crate's root anymore
File structure change broke them. This should fix them. Also, using the tests, properly made the WrapperApi macro(s) export at dlopen::wrapper::WrapperApi rather than the root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
I seldom work on rust code so any criticism would especially be appreciated with something this large of a change.
This comes after the work of #32 and fixes #31, as well as fixes #30, also technically fixes #29 and fixes #28 but this is only because this pr comes after #32.