Sprint crud #9
Sprint crud #9
Conversation
|
|
||
| @Override | ||
| @PostMapping(value = ADD_SPRINT) | ||
| public SprintResponse addNewSprint(@RequestParam String name, @RequestParam LocalDate startDate, |
There was a problem hiding this comment.
Zmień to na @RequestBody bo duży tych parametrów jest lepiej to w jakimś SprintRequest przerzucić
| private final SprintRepository sprintRepository; | ||
| private final SprintMapper sprintMapper; | ||
|
|
||
| public final SprintResponse addNewSprint(String name, LocalDate startDate, LocalDate endDate, String description) { |
There was a problem hiding this comment.
Daj te @Override przy metodach z interfejsu
| .orElseThrow(() -> new SprintDoesNotExistException(sprintId)); | ||
| log.info("Found sprint to update: {}", sprintToUpdate); | ||
|
|
||
| if (sprintToUpdate.getSprintEndDate().isBefore(startDate)) { |
There was a problem hiding this comment.
Dodaj w sprincie metodę isEndBefore(LocalDate date). Ogólnie to jest uważane za code smell bo nie powinno się robić gettera i potem wywoływać na nim warunku tylko powinno się to shermetyzować
| @@ -0,0 +1,18 @@ | |||
| package dev.corn.cornbackend.api.sprint.constants; | |||
|
|
|||
| public class SprintMappings { | |||
There was a problem hiding this comment.
final klasa i prywatny konstruktor
| import org.springframework.data.domain.Pageable; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface SprintRepository extends JpaRepository<Sprint, Long> { |
|
|
||
| public interface SprintRepository extends JpaRepository<Sprint, Long> { | ||
|
|
||
| Page<Sprint> findAllByOwnerOrderByName(User owner, Pageable pageable); |
There was a problem hiding this comment.
Ta metoda nie działa w spring data jpa bo w Sprint nie ma pola Owner spróbuj takiej sygnatury metody:
Page<Sprint> findAllByProjectOwnerOrderBySprintName(User owner, Pageable pageable);
No description provided.