Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored keycloak and added few options #57

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

szymonpoltorak
Copy link
Owner

No description provided.

Copy link
Collaborator

@igorkedzierawski igorkedzierawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad you haven't added any interface to this glorified config file

Comment on lines -65 to -73
providers.add(new IdentityProviderRepresentation() {{
setAlias("google");
setEnabled(true);
setProviderId("google");
setConfig(Map.of(
"clientId", GOOGLE_CLIENT_ID,
"clientSecret", GOOGLE_CLIENT_SECRET
));
}});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're not a fan of such instantiations

@igorkedzierawski igorkedzierawski dismissed their stale review March 3, 2024 21:06

It could be broken tho...

Copy link
Collaborator

@igorkedzierawski igorkedzierawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm it's working

@szymonpoltorak szymonpoltorak merged commit 20f8881 into devel Mar 3, 2024
1 check passed
@szymonpoltorak szymonpoltorak deleted the DEV-125-keycloakRefactor branch March 3, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants