Boards board #41

igorkedzierawski · 2024-02-19T18:03:53Z

szymonpoltorak · 2024-03-01T19:21:40Z

corn-frontend/src/app/pages/boards/board/board.component.html

+                            {{ isHidden(sliceWrapper) ? "chevron_right" : "expand_more" }}
+                        </mat-icon>
+                        <div class="flex items-center space-x-1">
+                            <img class="w-5 h-5 rounded-full" src="{{ slice.metadata.avatarUrl }}" />


brak alt attribute

szymonpoltorak · 2024-03-01T19:22:00Z

corn-frontend/src/app/pages/boards/board/board.component.html

        }
    </div>
 </div>
+
+<mat-menu #groupingMenu="matMenu">
+    @for (taskGrouping of TASK_GROUPINGS; track taskGrouping) {


błąd z typowaniem

szymonpoltorak · 2024-03-01T19:22:09Z

corn-frontend/src/app/pages/boards/board/board.component.ts

-            taskid: "t4",
-            assigneeAvatar: "/assets/corn-icons/icon-72x72.png",
-            assigneeName: "Bob Johnson"
+    protected filterString = "";


brak typowania

szymonpoltorak · 2024-03-01T19:22:14Z

corn-frontend/src/app/pages/boards/board/board.component.ts

-            assigneeAvatar: "/assets/corn-icons/icon-72x72.png",
-            assigneeName: "Bob Johnson"
+    protected filterString = "";
+    protected taskGrouping = TaskGrouping.BY_ASSIGNEE;


brak typowania

szymonpoltorak · 2024-03-01T19:23:04Z

corn-frontend/src/app/pages/boards/board/board.component.ts

czemu ten enum jest wewnątrz klasy. Powinien być w @enums

szymonpoltorak · 2024-03-01T19:39:15Z

corn-frontend/src/app/pages/boards/board/taskcard/taskcard.component.html

+        <div class="flex items-center justify-between">
+            <span class="text-gray-300 text-sm">{{ task.taskid }}</span>
+            <change-assignee-menu [associatedTask]="task">
+                <img


szymonpoltorak · 2024-03-01T19:39:31Z

corn-frontend/src/app/pages/boards/board/taskcard/taskcard.component.ts

+    imports: [
+        MatCardModule,
+        ChangeAssigneeMenuComponent,
+    ],
    templateUrl: './taskcard.component.html',
 })
 export class TaskcardComponent {


szymonpoltorak · 2024-03-01T19:40:39Z

corn-frontend/src/app/pages/boards/board/tasklist/tasklist.component.ts

+
+    @ViewChild('droplistInstance') private droplistInstance!: CdkDropList;
+
+    getDroplistInstance() {


DropList

typ

Możesz wykorzystać typescriptowego get'a zmienną nazwiesz z prefixem _ i będzie to sensowniejsze

szymonpoltorak · 2024-03-01T19:40:53Z

corn-frontend/src/app/pages/boards/board/tasklist/tasklist.component.ts

+export class TasklistComponent {
+
+    @Input() tasks: Task[] = [];
+    @Input() siblingDroplistInstances: any[] = [];


DropList,
Czemu any[]

szymonpoltorak · 2024-03-01T19:41:03Z

corn-frontend/src/app/pages/boards/board/tasklist/tasklist.component.ts

+        return this.droplistInstance;
+    }
+
+    protected droppedHandler(event: CdkDragDrop<Task[]>) {


…, segmented compound words and changed default value of TaskGrouping

…iate location

…s and services into separate files and placed them inside appropriate packets

szymonpoltorak · 2024-03-03T09:26:48Z

corn-frontend/src/app/pages/boards/board/model.service.ts

+import { Task } from '@core/interfaces/boards/board/task.interface';
+
+@Injectable()
+export class ModelService {


return types

szymonpoltorak · 2024-03-04T20:51:21Z

corn-frontend/src/app/core/services/boards/board/slice/slice.service.ts

@@ -1,17 +1,17 @@
 import { Injectable } from '@angular/core';
-import { SliceComponent } from './slice.component';
+import { SliceComponent } from '../../../../../pages/boards/board/slice/slice.component';


to możesz zastąpić za pomocą @pages

szymonpoltorak · 2024-03-04T20:51:37Z

corn-frontend/src/app/core/services/boards/board/slice/slices_model.service.ts

@@ -0,0 +1,112 @@
+import { Injectable, Input } from '@angular/core';
+import { SliceDescriptor } from '../../../../../pages/boards/board/slice/slice_descriptor';


to też @pages

szymonpoltorak · 2024-03-04T20:52:02Z

corn-frontend/src/app/pages/boards/board/board.component.ts

@@ -3,15 +3,21 @@ import { CommonModule } from '@angular/common';
 import { MatInputModule } from '@angular/material/input';
 import { MatButtonModule } from '@angular/material/button';
 import { MatMenuModule } from '@angular/material/menu';
-import { SlicesModelService, TaskChangedColumnEvent, TaskChangedGroupEvent, TaskGrouper } from './slice/slices_model.service';
-import { SliceService } from './slice/slice.service';
+import { SlicesModelService } from '../../../core/services/boards/board/slice/slices_model.service';


szymonpoltorak · 2024-03-04T20:52:10Z

corn-frontend/src/app/pages/boards/board/board.component.ts

-import { SlicesModelService, TaskChangedColumnEvent, TaskChangedGroupEvent, TaskGrouper } from './slice/slices_model.service';
-import { SliceService } from './slice/slice.service';
+import { SlicesModelService } from '../../../core/services/boards/board/slice/slices_model.service';
+import { SliceService } from '../../../core/services/boards/board/slice/slice.service';


szymonpoltorak · 2024-03-04T20:52:23Z

corn-frontend/src/app/pages/boards/board/change_assignee_menu/change_assignee_menu.component.ts

 import { CommonModule } from '@angular/common';
 import { MatInputModule } from '@angular/material/input';
 import { MatButtonModule } from '@angular/material/button';
 import { MatDividerModule } from '@angular/material/divider';
-import { ModelService } from '../model.service';
+import { BoardModelService } from '../../../../core/services/boards/board/model.service';


szymonpoltorak · 2024-03-04T20:52:35Z

corn-frontend/src/app/pages/boards/board/slice/slice.component.ts

@@ -1,11 +1,11 @@
 import { AfterViewInit, Component, Input, OnDestroy, ViewChild } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { TaskListComponent } from '../task_list/task_list.component';
-import { SliceService } from './slice.service';
+import { SliceService } from '../../../../core/services/boards/board/slice/slice.service';


Igor Kedzierawski added 2 commits February 17, 2024 22:05

initialize board path

d1d86c3

implemented basic board view

3d5cb5e

szymonpoltorak self-requested a review February 19, 2024 19:19

added missing features for board view

d00274b

szymonpoltorak requested changes Mar 1, 2024

View reviewed changes

Igor Kedzierawski added 6 commits March 1, 2024 21:21

added type declarations, added missing alt attributes to img elements…

d780099

…, segmented compound words and changed default value of TaskGrouping

improved styling

3b4bd1b

created type declaration for hidable objects

6283bb1

added return types for remaining untyped board methods

4d47a21

separated model from placeholder data and moved interfaces to appropr…

5d5632e

…iate location

improved typing, separated enums, interfaces and types from component…

57d9ccd

…s and services into separate files and placed them inside appropriate packets

szymonpoltorak requested changes Mar 4, 2024

View reviewed changes

Igor Kedzierawski added 3 commits March 4, 2024 22:01

improved imports readability

9ef08d9

moved slice_descriptor to more appropriate location

b42f7b7

improved imports readability

d69230d

szymonpoltorak approved these changes Mar 4, 2024

View reviewed changes

Merge branch 'devel' into boards-board

5265927

szymonpoltorak merged commit c7f979d into devel Mar 4, 2024
1 check passed

szymonpoltorak deleted the boards-board branch March 4, 2024 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Boards board #41

Boards board #41

igorkedzierawski commented Feb 19, 2024

szymonpoltorak Mar 1, 2024

szymonpoltorak Mar 1, 2024

szymonpoltorak Mar 1, 2024

szymonpoltorak Mar 1, 2024

szymonpoltorak Mar 1, 2024

szymonpoltorak Mar 1, 2024

szymonpoltorak Mar 1, 2024

szymonpoltorak Mar 1, 2024

szymonpoltorak Mar 1, 2024

szymonpoltorak Mar 1, 2024

szymonpoltorak Mar 3, 2024

szymonpoltorak Mar 4, 2024

szymonpoltorak Mar 4, 2024

szymonpoltorak Mar 4, 2024

szymonpoltorak Mar 4, 2024

szymonpoltorak Mar 4, 2024

szymonpoltorak Mar 4, 2024


		@ViewChild('droplistInstance') private droplistInstance!: CdkDropList;

		getDroplistInstance() {

		@@ -0,0 +1,112 @@
		import { Injectable, Input } from '@angular/core';
		import { SliceDescriptor } from '../../../../../pages/boards/board/slice/slice_descriptor';

Boards board #41

Boards board #41

Conversation

igorkedzierawski commented Feb 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment