Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html #86

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Update index.html #86

merged 1 commit into from
Jan 22, 2024

Conversation

Headedbranch225
Copy link
Contributor

Make the code show above the background, currently I only see the background but this fixes it

Make the code show above the background, currently I only see the background but this fixes it
@sz3
Copy link
Owner

sz3 commented Jan 10, 2024

Thanks for reporting this. I have a couple questions:

  1. which browser are you seeing this in?
  2. is it the whole box in the middle (blue/green pattern + text + barcode) that's hidden, or just the barcode?

@sz3
Copy link
Owner

sz3 commented Jan 10, 2024

Setting the z-index on the parent is mostly fine, but it does hide the intro text. My attempt is here, but I'm not sure if it resolves the problem you're seeing or not: 4997cac#diff-8f62b6ced28d3396b501d2e89a2e7cb761d16cd7dc977aebece03d4a5da5c24eR38-R41

@Headedbranch225
Copy link
Contributor Author

Headedbranch225 commented Jan 10, 2024

I am running firefox and it obly shows the background without the change being made, your change doesn't seem to work from a short test on my phone
It is the same for on windows Screenshot_20240110-134435_Firefox

@sz3
Copy link
Owner

sz3 commented Jan 11, 2024

That's interesting. I'm on FF 121 on linux and have a few different FF android versions I usually test with -- I don't see the issue...

But it's probably reasonable to fix it anyway. I'll try to put something together based on your fix. (unfortunately getting the text back is going to be slightly involved...)

@sz3
Copy link
Owner

sz3 commented Jan 11, 2024

Ok, trying again:
8f9caa1

index.html

I'm hoping that will do the right thing now that there's no negative z-index. It seems to work on chrome/safari/FF on linux and android, but apparently some firefoxes are special. 🙂

@sz3
Copy link
Owner

sz3 commented Jan 21, 2024

I made #87, which supercedes this PR and hopefully resolves the issue. Let me know if it doesn't...

@sz3 sz3 merged commit 38b8068 into sz3:master Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants