journal: modernize journal ratelimiting #32758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
YHNdnzj
reviewed
May 11, 2024
To make it follow our recent coding style.
'r' is usually used for storing return value.
This also makes journal_ratelimit_group_new() use structured initializer.
No functional change, just refactoring.
YHNdnzj
approved these changes
May 13, 2024
src/journal/journald-rate-limit.c
Outdated
| g->parent->n_groups--; | ||
| } | ||
| if (g->groups_by_id && g->id) | ||
| ordered_hashmap_remove(g->groups_by_id, g->id); |
There was a problem hiding this comment.
Maybe, assert_se(ordered_hashmap_remove_value(...))?
There was a problem hiding this comment.
assert_se() does not work here, as the entry is already removed if this is called from the destructor of the hashmap.
YHNdnzj
added
good-to-merge/with-minor-suggestions
and removed
please-review
|
@YHNdnzj Thank you for the review. Applied the above suggestions. Upgrading the green label. |
yuwata
added
the
good-to-merge/waiting-for-ci 👍
…oup with OrderedHashmap No functional change, just refactoring.
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.