Revert "core/exec-credential: complain louder if inherited credential is missing" #32754
Conversation
github-actions
bot
added
documentation
please-review
|
(this is just a placeholder. it's not supposed to be merged, or at least not like this, i just want that to make sure this is not forgotten before 256-rc2) |
There was a problem hiding this comment.
Hmm, my idea is like this: LoadCredential= should and should only be used when people are sure what they want. When a path is also specified, the missing cred is considered fatal, otherwise a warning is emitted. OTOH, if people want generic/completely optional stuff, they're better off using ImportCredential=. Our units are actually doing great, by always using ImportCredential= for acquiring credentials passed to service manager, no matter if globs are needed.
We could also just make LoadCredential= mandatory. However, that would become a complete compat break, which is something I'd like to avoid.
| @@ -3385,9 +3385,6 @@ StandardInputData=V2XigLJyZSBubyBzdHJhbmdlcnMgdG8gbG92ZQpZb3Uga25vdyB0aGUgcnVsZX | |||
| a terse way to declare credentials to inherit from the service manager into a service. This option | |||
| may be used multiple times, each time defining an additional credential to pass to the unit.</para> | |||
|
|
|||
| <para>Note that if the path is not specified or a valid credential identifier is given, i.e. | |||
There was a problem hiding this comment.
At least this should really be kept?
YHNdnzj
added
needs-discussion 🤔
and removed
please-review
|
IOW, I wouldn't think a warning makes much sense if we didn't have |
|
What about just downgrading to info level? |
| if (asprintf(&bindname, "@%" PRIx64 "/unit/%s/%s", random_u64(), unit, id) < 0) | ||
| if (asprintf(&bindname, "@%" PRIx64"/unit/%s/%s", random_u64(), unit, id) < 0) |
There was a problem hiding this comment.
This also. It is strange to have asymmetrical whitespace.
|
Let's continue the discussion in #32815. This revert also reverts the cleanups, which we don't want. |
Reverts #32689
I don't get what the point of that PR was? can somebody enlighten me?