test: Add TEST-85-NETWORK to run systemd-networkd-tests.py #32666

DaanDeMeyer · 2024-05-06T13:25:15Z

This adds a testsuite unit to run systemd-networkd-tests.py. This is
mkosi only for now as python is not available in the images set up
by the bash framework. We give the test a lower priority as it takes
a while to run so we want to start it as soon as possible.

github-actions · 2024-05-06T13:26:30Z

Important

An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released.

DaanDeMeyer · 2024-05-06T20:01:57Z

@yuwata Any chance you'd be able to help debug some of these failures? I don't think they're transient since it's the same distributions that are failing and succeeding on a second run. (Ignore centos 9 that one is the mirror being messed up)

yuwata · 2024-05-10T06:40:35Z

The failure on Fedora rawhide is caused by torvalds/linux@3ddc223.

yuwata · 2024-05-10T06:48:16Z

@davem330

Could you fix torvalds/linux@3ddc223 ?

https://github.com/torvalds/linux/blob/3ddc2231c8108302a8229d3c5849ee792a63230d/net/ipv4/devinet.c#L1695
Here, ifm->ifa_flags is u8, but ifa->ifa_flags is u32. So, some flags are lost in the below.
https://github.com/torvalds/linux/blob/3ddc2231c8108302a8229d3c5849ee792a63230d/net/ipv4/devinet.c#L1735

I missed that (struct ifaddrmsg)->ifa_flags was only 8bits, while (struct in_ifaddr)->ifa_flags is 32bits. Use a temporary 32bit variable as I did in set_ifa_lifetime() and check_lifetime(). Fixes: 3ddc223 ("inet: annotate data-races around ifa->ifa_flags") Reported-by: Yu Watanabe <[email protected]> Dianosed-by: Yu Watanabe <[email protected]> Closes: systemd/systemd#32666 (comment) Signed-off-by: Eric Dumazet <[email protected]>

yuwata · 2024-05-10T08:38:20Z

@DaanDeMeyer About the failure in CentOS, it seems the test wrongly detects that sch_fq_codel module does not exist. But, from https://gitlab.com/redhat/centos-stream/rpms/kernel/-/blob/c9s/kernel-x86_64-rhel.config, sch_fq_codel is enabled and built-in.
Maybe modprobe is broken??

DaanDeMeyer · 2024-05-10T08:50:40Z

@yuwata First of all, thank you for all the test fixes and investigations!

I will take a look at centos to see if I can figure out what's going on with the module.

I missed that (struct ifaddrmsg)->ifa_flags was only 8bits, while (struct in_ifaddr)->ifa_flags is 32bits. Use a temporary 32bit variable as I did in set_ifa_lifetime() and check_lifetime(). Fixes: 3ddc223 ("inet: annotate data-races around ifa->ifa_flags") Reported-by: Yu Watanabe <[email protected]> Dianosed-by: Yu Watanabe <[email protected]> Closes: systemd/systemd#32666 (comment) Signed-off-by: Eric Dumazet <[email protected]> Reviewed-by: Larysa Zaremba <[email protected]> Signed-off-by: NipaLocal <nipa@local>

I missed that (struct ifaddrmsg)->ifa_flags was only 8bits, while (struct in_ifaddr)->ifa_flags is 32bits. Use a temporary 32bit variable as I did in set_ifa_lifetime() and check_lifetime(). Fixes: 3ddc223 ("inet: annotate data-races around ifa->ifa_flags") Reported-by: Yu Watanabe <[email protected]> Dianosed-by: Yu Watanabe <[email protected]> Closes: systemd/systemd#32666 (comment) Signed-off-by: Eric Dumazet <[email protected]> Reviewed-by: Larysa Zaremba <[email protected]> Reviewed-by: David Ahern <[email protected]> Signed-off-by: NipaLocal <nipa@local>

yuwata · 2024-05-13T19:11:06Z

@DaanDeMeyer Thanks.

[ 1289.041546] systemd-networkd-tests.py[453]:   test_activation_policy_required_for_online (__main__.NetworkdNetworkTests.test_activation_policy_required_for_online) (policy='always-down', required='yes') ... FAIL
[ 1289.057316] systemd-journald[300]: [🡕] Suppressed 3126 messages from systemd-networkd.service

Huh...

yuwata · 2024-05-13T19:14:57Z

The test generates so many debugging logs. Could you add something like the following?

# /etc/systemd/journald.conf.d/disable-ratelimit.conf
[Journal]
RateLimitIntervalSec=0
RateLimitBurst=0

DaanDeMeyer · 2024-05-13T19:21:34Z

Once #32766 is in I am going to rework this to define one meson test per test class in systemd-networkd-tests.py as running them all in a single virtual machine takes way too long.

yuwata · 2024-05-13T20:01:02Z

Ah, I understand the failure. For some reasons, the test generates many debugging logs. The test checks journal but the expected line is suppressed because of ratelimiting. As I disabled journal ratelimiting on my laptop, so I could not reproduce the issue.

Unfortunately, the commit mkosi: Disable journald rate-limiting does not work, and still some lines are dropped.
From https://github.com/systemd/systemd/actions/runs/9068670883/job/24916498168?pr=32791

[   55.913557] systemd-networkd-tests.py[430]:   test_activation_policy_required_for_online (__main__.NetworkdNetworkTests.test_activation_policy_required_for_online) (policy='always-down', required='yes') ... FAIL
[   55.928592] systemd-journald[299]: [🡕] Suppressed 2112 messages from systemd-networkd.service

Anyway, really disabling journal ratelimiting should make the test passed, hopefully.

mkosi.images/system/mkosi.extra/usr/lib/systemd/journald.conf

I missed that (struct ifaddrmsg)->ifa_flags was only 8bits, while (struct in_ifaddr)->ifa_flags is 32bits. Use a temporary 32bit variable as I did in set_ifa_lifetime() and check_lifetime(). Fixes: 3ddc223 ("inet: annotate data-races around ifa->ifa_flags") Reported-by: Yu Watanabe <[email protected]> Dianosed-by: Yu Watanabe <[email protected]> Closes: systemd/systemd#32666 (comment) Signed-off-by: Eric Dumazet <[email protected]> Reviewed-by: Larysa Zaremba <[email protected]> Reviewed-by: David Ahern <[email protected]> Signed-off-by: NipaLocal <nipa@local>

I missed that (struct ifaddrmsg)->ifa_flags was only 8bits, while (struct in_ifaddr)->ifa_flags is 32bits. Use a temporary 32bit variable as I did in set_ifa_lifetime() and check_lifetime(). Fixes: 3ddc223 ("inet: annotate data-races around ifa->ifa_flags") Reported-by: Yu Watanabe <[email protected]> Dianosed-by: Yu Watanabe <[email protected]> Closes: systemd/systemd#32666 (comment) Signed-off-by: Eric Dumazet <[email protected]> Reviewed-by: Larysa Zaremba <[email protected]> Reviewed-by: David Ahern <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>

yuwata · 2024-05-14T20:52:43Z

Again, I think we should add a dummy Makefile something like that in TEST-85:

# SPDX-License-Identifier: LGPL-2.1-or-later

all setup run clean clean-again:
	true

.PHONY: all setup run clean clean-again

yuwata · 2024-05-14T20:53:42Z

test/TEST-85-NETWORK/meson.build

+ 'NetworkdDHCPClientTests',
+ 'NetworkdDHCPPDTests',
+ 'NetworkdIPv6PrefixTests',
+ 'NetworkdMTUTests',


Is it possible to get the list dynamically? Otherwise, newly added tests are easily forgotten.

I tried but couldn't find a way to get it working. If you can figure out how to get the tests dynamically we can update this to use that.

How about to call simple command something like the following?

sed -ne '/^class .*Tests/ { s/^class *//; s/(.*$//; p}' systemd-networkd-tests.py

But, it is OK to done later in another PR.

This adds a testsuite unit to run systemd-networkd-tests.py. This is mkosi only for now as python is not available in the images set up by the bash framework. We give the test a lower priority as it takes a while to run so we want to start it as soon as possible.

yuwata

LGTM. Several further comments. But feel free to leave them to another PR.

test/test-network/systemd-networkd-tests.py

yuwata · 2024-05-14T21:12:10Z

test/TEST-85-NETWORK/meson.build

+ 'NetworkdDHCPClientTests',
+ 'NetworkdDHCPPDTests',
+ 'NetworkdIPv6PrefixTests',
+ 'NetworkdMTUTests',


How about to call simple command something like the following?

sed -ne '/^class .*Tests/ { s/^class *//; s/(.*$//; p}' systemd-networkd-tests.py

But, it is OK to done later in another PR.

Follow-up for systemd#32666.

Follow-up for #32666.

Otherwise, several tests for networkd are skipped. Follow-up for systemd#32666.

github-actions bot added build-system tests meson please-review PR is ready for (re-)review by a maintainer labels May 6, 2024

DaanDeMeyer force-pushed the mkosi-network branch from bf72967 to c07392e Compare May 6, 2024 14:22

bluca added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed please-review PR is ready for (re-)review by a maintainer labels May 6, 2024

DaanDeMeyer force-pushed the mkosi-network branch from c07392e to b5d471b Compare May 6, 2024 16:17

github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels May 6, 2024

bluca added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed please-review PR is ready for (re-)review by a maintainer labels May 6, 2024

DaanDeMeyer force-pushed the mkosi-network branch from b5d471b to c847a8d Compare May 6, 2024 18:21

github-actions bot added please-review PR is ready for (re-)review by a maintainer and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels May 6, 2024

DaanDeMeyer mentioned this pull request May 6, 2024

Various mkosi fixes #32673

Merged

DaanDeMeyer force-pushed the mkosi-network branch 2 times, most recently from c745863 to 1db84ef Compare May 7, 2024 19:22

bluca added the ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR label May 8, 2024

DaanDeMeyer force-pushed the mkosi-network branch from 1db84ef to c06e44f Compare May 9, 2024 10:57

github-actions bot removed the ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR label May 9, 2024

yuwata mentioned this pull request May 10, 2024

test-network: several improvements for running with mkosi #32743

Merged

DaanDeMeyer force-pushed the mkosi-network branch from 3163806 to 3f4897b Compare May 13, 2024 19:19

yuwata reviewed May 13, 2024

View reviewed changes

mkosi.images/system/mkosi.extra/usr/lib/systemd/journald.conf Outdated Show resolved Hide resolved

DaanDeMeyer force-pushed the mkosi-network branch from 3f4897b to d12a771 Compare May 13, 2024 20:08

DaanDeMeyer force-pushed the mkosi-network branch from d12a771 to 5fe75f0 Compare May 14, 2024 13:23

yuwata reviewed May 14, 2024

View reviewed changes

DaanDeMeyer added 3 commits May 14, 2024 22:58

mkosi: Disable journald rate-limiting

16585db

test: Allow using TEST_MATCH_TESTCASE with systemd-networkd-tests.py

15c1a78

DaanDeMeyer force-pushed the mkosi-network branch from 5fe75f0 to aa09f30 Compare May 14, 2024 20:58

yuwata approved these changes May 14, 2024

View reviewed changes

DaanDeMeyer merged commit 985ea31 into systemd:main May 15, 2024
40 of 44 checks passed

DaanDeMeyer deleted the mkosi-network branch May 15, 2024 05:30

github-actions bot removed the please-review PR is ready for (re-)review by a maintainer label May 15, 2024

yuwata added a commit to yuwata/systemd that referenced this pull request May 17, 2024

test: dynamically generate list of test cases

eaca7bc

Follow-up for systemd#32666.

yuwata mentioned this pull request May 17, 2024

test: dynamically generate list of test cases #32878

Merged

yuwata added a commit that referenced this pull request May 17, 2024

test: dynamically generate list of test cases

5144586

Follow-up for #32666.

yuwata added a commit to yuwata/systemd that referenced this pull request May 19, 2024

test: install more kernel modules for Fedora image

7132693

Otherwise, several tests for networkd are skipped. Follow-up for systemd#32666.

yuwata mentioned this pull request May 19, 2024

test: install more kernel modules for Fedora image #32928

Closed

yuwata added a commit to yuwata/systemd that referenced this pull request May 20, 2024

test: install more kernel modules for Fedora image

9495f5a

Otherwise, several tests for networkd are skipped. Follow-up for systemd#32666.

yuwata added a commit to yuwata/systemd that referenced this pull request May 20, 2024

test: install more kernel modules for Fedora image

34c82ba

Otherwise, several tests for networkd are skipped. Follow-up for systemd#32666.

yuwata added a commit to yuwata/systemd that referenced this pull request May 20, 2024

test: install more kernel modules for Fedora image

1e67b4d

Otherwise, several tests for networkd are skipped. Follow-up for systemd#32666.

yuwata added a commit to yuwata/systemd that referenced this pull request May 20, 2024

test: install more kernel modules for Fedora image

90fe8cf

Otherwise, several tests for networkd are skipped. Follow-up for systemd#32666.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Add TEST-85-NETWORK to run systemd-networkd-tests.py #32666

test: Add TEST-85-NETWORK to run systemd-networkd-tests.py #32666

DaanDeMeyer commented May 6, 2024 •

edited by github-actions bot

github-actions bot commented May 6, 2024

DaanDeMeyer commented May 6, 2024

yuwata commented May 10, 2024

yuwata commented May 10, 2024

yuwata commented May 10, 2024

DaanDeMeyer commented May 10, 2024

yuwata commented May 13, 2024

yuwata commented May 13, 2024

DaanDeMeyer commented May 13, 2024

yuwata commented May 13, 2024

yuwata commented May 14, 2024

yuwata May 14, 2024

DaanDeMeyer May 14, 2024

yuwata May 14, 2024

yuwata left a comment

yuwata May 14, 2024

test: Add TEST-85-NETWORK to run systemd-networkd-tests.py #32666

test: Add TEST-85-NETWORK to run systemd-networkd-tests.py #32666

Conversation

DaanDeMeyer commented May 6, 2024 • edited by github-actions bot

github-actions bot commented May 6, 2024

DaanDeMeyer commented May 6, 2024

yuwata commented May 10, 2024

yuwata commented May 10, 2024

yuwata commented May 10, 2024

DaanDeMeyer commented May 10, 2024

yuwata commented May 13, 2024

yuwata commented May 13, 2024

DaanDeMeyer commented May 13, 2024

yuwata commented May 13, 2024

yuwata commented May 14, 2024

yuwata May 14, 2024

Choose a reason for hiding this comment

DaanDeMeyer May 14, 2024

Choose a reason for hiding this comment

yuwata May 14, 2024

Choose a reason for hiding this comment

yuwata left a comment

Choose a reason for hiding this comment

yuwata May 14, 2024

Choose a reason for hiding this comment

DaanDeMeyer commented May 6, 2024 •

edited by github-actions bot