Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/service: imply Type=exec if credentials are used #32612

Merged
merged 2 commits into from
Jul 21, 2024
Merged

core/service: imply Type=exec if credentials are used #32612

merged 2 commits into from
Jul 21, 2024

Commits on Jul 21, 2024

  1. test-execute: ExecStop= and friends should not get credentials 

    See systemd#32583
    @YHNdnzj @bluca
    YHNdnzj authored and bluca committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    60b218e View commit details
    Browse the repository at this point in the history

  2. core/service: imply Type=exec if credentials are used 

    When credentials are used with Type=simple + ExecStartPost=,
i.e. when multiple sd-executor instances are running in parallel
for a single service, the state of final credential dir
might be unexpected wrt path_is_mount_point() and other
steps. So, let's imply Type=exec if not explicitly specified,
and emit a warning otherwise.
    @YHNdnzj @bluca
    YHNdnzj authored and bluca committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    757e469 View commit details
    Browse the repository at this point in the history