Revert "TEST-19-CGROUP: Skip on opensuse"

[Werkov]

This reverts commit 60d064d.

systemd-run --wait --unit=test-0.service --property=DynamicUser=1 --property=Delegate= test -w /sys/fs/cgroup/system.slice/test-0.service/ -a -w /sys/fs/cgroup/system.slice/test-0.service/memory.oom.group

is suspicious as it only relies on test-0.service:MemoryAccounting=yes (or anything that enables memory controller in test-0.service) which isn't set on openSUSE.

Draft PR to troubleshoot the test.

Ref: #32439

[github-actions]

Important

An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released.

[DaanDeMeyer]

@Werkov With meson from git you can debug locally with something like follows:

../meson/meson.py compile -C build mkosi && SYSTEMD_INTEGRATION_TESTS=1 ../meson/meson.py test -C build --no-rebuild -i TEST-19-CGROUP

[Werkov]

(The force push is only rebase on current main, it closed PR accidentaly.)

Thanks for the tip about local runs. As dictated by Murphy's law, the test didn't fail when I ran it locally. Nevertheless, the fix for the test is still valid and should prevent future failures of TEST-19-CGROUP.delegate.sh.

The reason for not failing in my environment is that something kept memory in system.slice's enabled_mask and thus the test unit had unwittingly memory controller enabled and the test passed.

That's a different issue and I'm only sending delegate test inclusion again here.

(It looks like system.slice retained memory controller because of systemd-oomd.service's MemoryLow= setting although the oomd service was not running, i.e. not realized. I suspect 9cc5454 may have subtly change caching of the masks. If I have isolated reproducer, I will file a separate issue for that.)

[Werkov]

future failures of TEST-19-CGROUP.delegate.sh.

The actual issues that I saw in CI logged artifacts were due to memory controller. The device mapper message was either a red herring or another issue.

[Werkov]

(TEST-64-UDEV-STORAGE-mdadm_basic failed in CI, passes locally. It have timed out, lets's see how deterministic it is.
E: 2nd re-run passes.)