Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update S3 access policy in cloudlogs-related templates #108

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Update S3 access policy in cloudlogs-related templates #108

merged 2 commits into from
Oct 26, 2023

Conversation

gi-erre
Copy link
Contributor

@gi-erre gi-erre commented Oct 23, 2023

The update to the S3 policy is necessary to properly access the audit logs stored in S3 covering all the corner cases.

@gi-erre gi-erre marked this pull request as ready for review October 23, 2023 17:39
@gi-erre gi-erre requested review from a team as code owners October 23, 2023 17:39
ravinadhruve10
ravinadhruve10 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nkraemer-sysdig
nkraemer-sysdig approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@nkraemer-sysdig nkraemer-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the frontend already setting the accountID as a URL parameter when linking to the CFT?

@gi-erre
Copy link
Contributor Author

gi-erre commented Oct 26, 2023

Is the frontend already setting the accountID as a URL parameter when linking to the CFT?

Yes, afaik the frontend already takes care of passing all the parameters that receives from the BE side, once that will be updated we should be fine

@gi-erre gi-erre merged commit 5a5a0b1 into main Oct 26, 2023
4 checks passed
@gi-erre gi-erre deleted the fix/jojo/support-multi-region-cloudlogs branch October 26, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkraemer-sysdig nkraemer-sysdig nkraemer-sysdig approved these changes

@ravinadhruve10 ravinadhruve10 ravinadhruve10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gi-erre @nkraemer-sysdig @ravinadhruve10