-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d3 v4 and TypeScipt #344
base: master
Are you sure you want to change the base?
d3 v4 and TypeScipt #344
Conversation
I would go ahead and use your fork as the main development branch. I don't have time to maintain/evolve this version, so there's definitely room for a better implementation to take over. Typescript is a good idea, I just don't want to add another layer here for anyone who's been using the library for a while. |
Hmm, well @syntagmatic the main idea with TypeScript is that you just add type annotations and it'll still compile down to pure JavaScript. So people won't need to change a line of their code to use it as a library, and for those developing they get type hints. This is especially useful in this case, where many
Regardless would you be able to resolve my queries when I have questions about why things don't work? E.g.: what is parallel-coordinates/d3.parcoords.js Line 527 in 4259bf2
k meant to be at: parallel-coordinates/d3.parcoords.js Line 339 in 4259bf2
|
I'm not sure what the $V references, it may have been related to a vector library. That |
Hmm, alright. Okay @syntagmatic I have finished rewriting d3.parcoords so it compiles in TypeScript. Now down to the d3 v3 → v4 upgrade: Can you assist with the d3 v3 → v4 upgrade? |
Added little TODO helpers with a candidate rewrite when it wasn't a 1:1 replacement in implementation (e.g.: flattened namespace or rename):
Then just:
Not sure about multibrush, but it's kind of optional anyway so we can put it to one side for now. |
@SamuelMarks Pretty sure $V comes from sylvester: http://sylvester.jcoglan.com/ |
Oh good, it has types: https://www.npmjs.com/package/@types/sylvester |
Great work. Thanks for doing this @SamuelMarks! |
I've done some work to upgrade to the latest d3; and also rewrote in TypeScript.
@syntagmatic ; not sure what your plans are for this library.