Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lottie Exporter] Add documentation for shade layer #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saurabh-ramola
Copy link
Member

Added documentation for shade layer.
@AnishGG please check ^__^

@saurabh-ramola saurabh-ramola requested a review from AnishGG August 16, 2020 14:51
@morevnaproject
Copy link
Member

@AnishGG Can you check, please? ^__^

@morevnaproject
Copy link
Member

Can anyone look at this? ^__^

Copy link
Member

@AnishGG AnishGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left one comment on this. That is the only doubt I have, otherwise this PR looks ok.

+--------------+---------------------+-----------------+
| Amount | |tick| | |tick| |
+--------------+---------------------+-----------------+
| Blend Method | |cross| | |minus| |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does shade layer not support blend methods at all? I don't remember this actually.
Can someone test the lottie exporter to check this ^__^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants