Add support for custom ALPN #9529
Open
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "bep-relay" as default but allow custom ALPNs if the relay server is used for something unrelated to "bep-relay".
|
I'm not sure we want to build general relay infrastructure for non-Syncthing use cases though? I mean, the proposed diff is trivial and harmless for sure, but I question the expansion of scope it implies... |
|
Well, maybe syncthing will have benefit, too. The developer community could grow with it. But I doubt that there will be a big impact because of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "bep-relay" as default but allow custom ALPNs if the relay server is used for something unrelated to "bep-relay".
Purpose
This allows to use the perfect syncthing-relay for another usage for different applications without to have conflicts with syncthing application itself and custom application.
Testing
Used "testutil" of strelaysrv and saw that it shows an error in log output if the ALPN does not match. Also used wireshark to see the TLS alert "No application protocol".
Authorship
André Klitzing [email protected]