Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-robot list inclusion (#1797) #1798

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

dpoon
Copy link
Contributor

@dpoon dpoon commented Feb 15, 2024

If the Sympa::List->new($name, $robot, $options) constructor is called with an optional $robot parameter specified, then that $robot overrides any domain that may be present in $name. When constructing a DataSource for inclusion, the robot of the DataSource should be inferred only if no domain is present in the list name.

If the Sympa::List->new($name, $robot, $options) constructor is called with an optional $robot parameter specified, then that $robot overrides any domain that may be present in $name.  When constructing a DataSource for inclusion, the robot of the DataSource should be inferred only if no domain is present in the list name.
@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Mar 4, 2024
@benjyamon
Copy link

We ran into this bug and applied this fix to our production version 6.2.72 and it's fixed! So thanks and +1 to this pull request making it's way into a future release ;)

@ikedas ikedas merged commit 2101d9c into sympa-community:main Sep 6, 2024
16 checks passed
@ikedas ikedas added this to the 6.2.74 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready A PR is waiting to be merged. Close to be solved
Projects
None yet
3 participants