Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evil-fringe-mark to +spacemacs/spacemacs-evil #16770

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+7 −0
Open

Add evil-fringe-mark to +spacemacs/spacemacs-evil #16770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions layers/+spacemacs/spacemacs-evil/packages.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
(evil-escape :location (recipe :fetcher github
:repo "smile13241324/evil-escape"))
evil-exchange
evil-fringe-mark
evil-goggles
evil-iedit-state
evil-indent-plus
Expand Down Expand Up @@ -155,6 +156,12 @@
(define-key evil-visual-state-map evil-exchange-cancel-key
'evil-exchange-cancel))))

(defun spacemacs-evil/init-evil-fringe-mark ()
(use-package evil-fringe-mark
:config
(setq-default evil-fringe-mark-show-special t)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to set options in the :init or :custom block. It makes them easier to override by users when the package is deferred.

(global-evil-fringe-mark-mode)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add this package, it should be deferred, and the mode should not be enabled by default. It would make sense to add a toggle as for evil-visual-mark-mode, SPC t ' seems logical as a key binding.


(defun spacemacs-evil/init-evil-goggles ()
(use-package evil-goggles
:defer t
Expand Down
Loading