Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[github-copilot] Fix activation for holy-mode #16760

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[github-copilot] Fix activation for holy-mode #16760

wants to merge 1 commit into from

Conversation

fnussbaum
Copy link
Collaborator

Completions were disabled by default due to holy-mode permanently activating evil-emacs-state. See for example copilot-emacs/copilot.el#124.

@fnussbaum
[github-copilot] Fix activation for holy-mode
5b45ced 
Completions were disabled by default due to `holy-mode` permanently activating
`evil-emacs-state`.
@fnussbaum fnussbaum force-pushed the fix-copilot-holy-mode branch from e71300e to 5b45ced Compare December 27, 2024 21:32
@fnussbaum fnussbaum marked this pull request as draft December 30, 2024 01:06
@fnussbaum
Copy link
Collaborator Author

fnussbaum commented Dec 30, 2024 •
edited
Loading

On second thought, it might be better to suggest enabling copilot in evil-emacs-state (or even for all evil states with non-nil :input-method property) upstream first. I originally rejected this idea, and am still not sure that enabling it there is necessarily the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fnussbaum