Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[geolocation] Small fixes and cleanups #16736

Merged
merged 2 commits into from
Dec 31, 2024
Merged

[geolocation] Small fixes and cleanups #16736

merged 2 commits into from
Dec 31, 2024

Conversation

bcc32
Copy link
Collaborator

@bcc32 bcc32 commented Dec 18, 2024

  1. Remove the deprecated extensions.el file which is no longer used
  2. Handle themes that have a :package property correctly

@bcc32 bcc32 requested a review from smile13241324 December 19, 2024 01:08
@bcc32
Copy link
Collaborator Author

bcc32 commented Dec 19, 2024

@smile13241324 would appreciate a quick confirmation that extensions.el is indeed not used by anything anymore. (I think the deprecation I saw pre-dates me following this repo closely).

@smile13241324
Copy link
Collaborator

I'll have a look

smile13241324
smile13241324 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@smile13241324 smile13241324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@smile13241324 smile13241324 merged commit 6c00eb8 into syl20bnr:develop Dec 31, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smile13241324 smile13241324 smile13241324 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcc32 @smile13241324